#32643 [Opn->Asn]: update tidy to reflect library change in tidyLoadConfig()

ID: 32643 Updated by: nlopess@php.net Reported By: nlopess@php.net -Status: Open +Status: Assigned Bug Type: Feature/Change Request Operating System: n/a PHP Version: 5CVS-2005-04-09 (dev) Assigned To: john Previous Comments: ------------------------------------------------------------------------ [2005-04-26 15:28:48] nlopess@php.net With the current behaviour, you stop the parsing (i.e. tidy_parse_x()) if the configuration file isnt found *or* there was an error while parsing the config file. IMHO, this is incorrect, because if you have a typo in the config file you could continue and parse the html. Even if you decide not to apply that change, you could apply the switch() part to give different errors. ------------------------------------------------------------------------ [2005-04-25 22:52:29] john@php.net Opps... meant to close the other report... I'm a little skeptical about this patch at first glance because you are changing the behavior from immediately returning to simply throwing a warning and continuing execution. Regardless of if the config file failed at parsing, or the config file failed to load they both should stop execution as far as I would think -- can you give me a reason otherwise? ------------------------------------------------------------------------ [2005-04-25 22:50:11] john@php.net This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2005-04-19 20:39:24] nlopess@php.net Assigning to the extension maintainer. ------------------------------------------------------------------------ [2005-04-09 13:59:40] nlopess@php.net Description: ------------ I've made a patch (which is backward compatible with older libraries) to update the tidy extension due to a change in the libtidy function tidyLoadConfig(). The change is described at: http://sourceforge.net/tracker/?func=detail&atid=390963&aid=937271&group_id=27659 The patch: http://livedocs.aborla.net/patch.php?id=php.tidy Nuno ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=32643&edit=1