#35062 [Opn->Asn]: [PATCH] socket_read() produces warnings on non blocking sockets

ID: 35062 Updated by: sniper@php.net -Summary: socket_read() produces warnings on non blocking sockets Reported By: dima at dimych dot sumy dot ua -Status: Open +Status: Assigned Bug Type: Sockets related -Operating System: FreeBSD 4.9-STABLE #0 +Operating System: * -PHP Version: 4.4.1RC1 +PHP Version: 5CVS, 4CVS (2005-11-10) (cvs) -Assigned To: +Assigned To: nlopess New Comment: Nuno, I think you will only get some feedback on your patch if you either commit it, or post it to internals list. Previous Comments: ------------------------------------------------------------------------ [2005-11-10 00:17:12] nlopess@php.net After the reading the bug report carefully, the only problem here is that socket_read() shouldn't produce a warning when errno==EAGAIN. The return value of the function doesn't need/can't be changed. The constant SOCKET_EAGAIN is already defined, so there's also a doc bug :) (all SOCKET_* need to be documented) The patch: http://mega.ist.utl.pt/~ncpl/php_bug_35062.txt ------------------------------------------------------------------------ [2005-11-06 23:22:15] sniper@php.net Nuno, since you seem to know the problem, feel free to fix it. ------------------------------------------------------------------------ [2005-11-05 22:13:26] nlopess@php.net opening it again, as this seems a different issue. We should have the EAGAIN constant and use it for non-blocking sockets. returning false isnt't a good idea. ------------------------------------------------------------------------ [2005-11-04 16:23:08] sniper@php.net Please do not submit the same bug more than once. An existing bug report already describes this very problem. Even if you feel that your issue is somewhat different, the resolution is likely to be the same. Thank you for your interest in PHP. See bug #21197 ------------------------------------------------------------------------ [2005-11-04 14:53:52] dima at dimych dot sumy dot ua Im look everyware in the Internet and dont find any workaround for this problem. And error logs still growing... This code decreases count of warnings: -- code -- $startTime = microtime_float(true); socket_send($socket, $package, strLen($package), 0); socket_set_block($socket); $to = array('sec' => 0, 'usec' => 500000); socket_set_option($socket, SOL_SOCKET, SO_RCVTIMEO, $to); if (socket_read($socket, 4096)) { socket_close($socket); return microtime_float() - $startTime; } socket_close($socket); -- end of code -- my "ping" function launches once per 5 minutes for around 50 hosts, but not all of them alive. Dead hosts causes warnings. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/35062 -- Edit this bug report at http://bugs.php.net/?id=35062&edit=1