#35341 [Asn]: Fix for bug 33760 breaks build with older curl

ID: 35341 User updated by: selsky at columbia dot edu Reported By: selsky at columbia dot edu Status: Assigned Bug Type: cURL related Operating System: Solaris PHP Version: 4CVS-2005-11-22 (snap) Assigned To: mike New Comment: With the "--feature" change, configure correctly reports the following: checking for CURL support... yes checking for cURL 7.9.8 or greater... libcurl 7.11.1 checking for SSL support in libcurl... yes checking for SSL library used... openssl checking openssl/crypto.h usability... no checking openssl/crypto.h presence... no checking for openssl/crypto.h... no checking for curl_easy_perform in -lcurl... yes checking for curl_version_info in -lcurl... yes Previous Comments: ------------------------------------------------------------------------ [2005-11-22 23:28:57] tony2001@php.net Mike, check the patch, plz. ------------------------------------------------------------------------ [2005-11-22 23:25:31] selsky at columbia dot edu My bad. Both patches are needed. Your patch fixed the bash warnings, but without my patch, configure says this: checking for CURL support... yes checking for cURL 7.9.8 or greater... libcurl 7.11.1 checking for SSL support in libcurl... no checking for curl_easy_perform in -lcurl... yes checking for curl_version_info in -lcurl... yes However, my curl is built with SSL. $ curl-config --feature SSL IPv6 libz Thanks for your time. ------------------------------------------------------------------------ [2005-11-22 23:14:46] tony2001@php.net Apparently your patch cannot fix the problem with "==". ------------------------------------------------------------------------ [2005-11-22 23:11:32] selsky at columbia dot edu Here's a patch against the PHP_4_4 branch: $ cvs -q diff -u ext/curl/config.m4 Index: ext/curl/config.m4 ======================================================== =========== RCS file: /repository/php-src/ext/curl/config.m4,v retrieving revision 1.20.2.2.2.1 diff -u -r1.20.2.2.2.1 config.m4 --- ext/curl/config.m4 2 Nov 2005 15:03:36 -0000 1.20.2.2.2.1 +++ ext/curl/config.m4 22 Nov 2005 22:07:30 -0000 @@ -50,7 +50,7 @@ fi AC_MSG_CHECKING([for SSL support in libcurl]) - CURL_SSL=$CURL_CONFIG --features | $EGREP SSL + CURL_SSL=$CURL_CONFIG --feature | $EGREP SSL if test "$CURL_SSL" == "SSL"; then AC_MSG_RESULT([yes]) AC_DEFINE([HAVE_CURL_SSL], [1], [Have cURL with SSL support]) ------------------------------------------------------------------------ [2005-11-22 22:51:44] tony2001@php.net Please try this patch: http://tony2001.phpclub.net/dev/tmp/bug35341.diff Apply it with patch -p0 < bug35341,diff and don't forget to run ./buildconf after that. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/35341 -- Edit this bug report at http://bugs.php.net/?id=35341&edit=1