#35711 [Ana->Asn]: [PATCH] ISO-8859 charset not correctly detected

ID: 35711 Updated by: sniper@php.net Reported By: matteo at beccati dot com -Status: Analyzed +Status: Assigned Bug Type: mbstring related Operating System: Debian GNU/Linux PHP Version: 5.1CVS-2005-12-24 (snap) Assigned To: hirokawa Previous Comments: ------------------------------------------------------------------------ [2005-12-25 10:40:42] hirokawa@php.net O.K., I will commit your patch with minor modification. ------------------------------------------------------------------------ [2005-12-24 14:38:32] tony2001@php.net Rui, could you take a look at this once again? ------------------------------------------------------------------------ [2005-12-24 13:59:10] matteo at beccati dot com I've made a patch which adds an mbstring.strict_detection php.ini flag that specifies the default behaviour (defaults to off). I just started taking a look to PHP internals so I could have made mistakes; make test passes the mbstring related checks, I'll do more tests later. http://beccati.com/download/mbstring-patch-20051224.txt ------------------------------------------------------------------------ [2005-12-24 12:30:08] matteo at beccati dot com These are great news and I'm really thankful for your help. Now mb_detect_encoding is correctly working when the strict flag is set, but... - There's no way to set the strict flag in mb_convert_encoding; however one could use mb_detect_encoding with the strict flag as source charset. - There's no way to set the strict flag for http_input translation, which indeed would be much more useful (that's how I found the problem described here). ------------------------------------------------------------------------ [2005-12-24 02:23:06] hirokawa@php.net This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. The character-end detection was introduced in the strict mode (mb_detect_encoding ($s,$list,TRUE)). Please try the strict mode. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/35711 -- Edit this bug report at http://bugs.php.net/?id=35711&edit=1