#37392 [Opn->Csd]: Unnecessary call to OCITransRollback() at the end of request

ID: 37392 Updated by: tony2001@php.net Reported By: cjbj at hotmail dot com -Status: Open +Status: Closed Bug Type: OCI8 related Operating System: n/a PHP Version: 5.1.4 New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Thanks, Chris. Previous Comments: ------------------------------------------------------------------------ [2006-05-10 02:24:39] cjbj at hotmail dot com Description: ------------ Php_oci_persistent_helper() calls php_oci_connection_rollback() without checking connection->needs_commit. This results in an unnecessary call to OCITransRollback() at the end of request for persistent connections. Reproduce code: --------------- <?php echo "<pre>"; oci_internal_debug(1); $conn = oci_pconnect("hr", "hr", "//localhost/XE"); $query = 'select * from dual'; $stid = oci_parse($conn, $query); oci_execute($stid, OCI_DEFAULT); oci_rollback($conn); echo "</pre>"; ?> Expected result: ---------------- ... OCI8 DEBUG: OCITransRollback at (/tmp/php-5.1.3/ext/oci8/oci8.c:1400) OCI8 DEBUG: OCIStmtRelease at (/tmp/php-5.1.3/ext/oci8/oci8_statement.c:589) ... Actual result: -------------- ... OCI8 DEBUG: OCITransRollback at (/tmp/php-5.1.3/ext/oci8/oci8.c:1400) OCI8 DEBUG: OCITransRollback at (/tmp/php-5.1.3/ext/oci8/oci8.c:1400) OCI8 DEBUG: OCIStmtRelease at (/tmp/php-5.1.3/ext/oci8/oci8_statement.c:589) ... ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=37392&edit=1