#37394 [Opn->Csd]: erroneous parameter check in substr_compare

From: Date: Wed, 10 May 2006 13:08:02 +0000
Subject: #37394 [Opn->Csd]: erroneous parameter check in substr_compare
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-96913@lists.php.net to get a copy of this message 
 ID:               37394
 Updated by:       iliaa@php.net
 Reported By:      sivann at cs dot ntua dot gr
-Status:           Open
+Status:           Closed
 Bug Type:         Unknown/Other Function
 Operating System: Linux
 PHP Version:      5.1.4
 New Comment:

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2006-05-10 11:20:54] sivann at cs dot ntua dot gr

Description:
------------
substr_compare shouldn't output warning and return FALSE if the
"length" parameter *equals* the length of main_str. It should do that
only if length > strlen(main_str). 

Moreover an invalid error is returned: "The start position cannot
exceed initial string length" even if specifying start position 0.

This error didn't exist in version 5.1.0.

Reproduce code:
---------------
echo substr_compare("abcd","abcd",0,4);




Expected result:
----------------
it should do the same as this (return 0):
echo substr_compare("abcd","abcd",0);


Actual result:
--------------
Warning: substr_compare() [function.substr-compare]: The start position
cannot exceed initial string length in ...


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=37394&edit=1

Thread (2 messages)

« previous php.bugs (#96913) next »