Bug #17389 Updated: max_upload_filesize setting format is problematic

ID: 17389 Updated by: sniper@php.net Reported By: sean@digitalspinner.com Status: Open -Bug Type: *Configuration Issues +Bug Type: PHP options/info functions Operating System: Linux PHP Version: 4.2.1 Previous Comments: ------------------------------------------------------------------------ [2002-05-23 10:07:41] sean@digitalspinner.com The documentation states that max_upload_filesize is an integer, although the result from ini_get is "2M". This is problematic for the following reasons: 1. With the documentation stating the format as an integer, code can be written to output BAD code such as: $my_value = 2M; I fell into this trap and didn't locate the problem easily because my test installations (unfortunately) stated the max_upload_filesize as a true integer inside php.ini. 2. It is not clear how PHP handles the output of GOOD code like: $my_value = "2M"; If I later have code like: if ($my_value > $this_value) // i.e., if ("2M" > "345") Will it break? Will "2M" be considered an integer and converted automatically to 2097152? If this is the case then it is not immediately evident inside of the documentation. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=17389&edit=1