#30157 [Asn]: ftell() function does not use stream_tell()

From: Date: Wed, 26 Jul 2006 16:43:31 +0000
Subject: #30157 [Asn]: ftell() function does not use stream_tell()
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-99943@lists.php.net to get a copy of this message
ID: 30157 Updated by: wez@php.net Reported By: tendencies at free dot fr Status: Assigned Bug Type: Streams related Operating System: * PHP Version: 5CVS-2004-09-19 (dev) Assigned To: pollita New Comment: (PS: I got here via Bug #37096) Previous Comments: ------------------------------------------------------------------------ [2006-07-26 16:42:25] wez@php.net I truly hope that this patch didn't get committed; it's not part of the streams design and is fundamentally redundant. I don't have time to make any further commentary than that; further analysis of the user-stream case mentioned in this bug report is required, but it certainly does not require making this kind of change to the core. ------------------------------------------------------------------------ [2005-06-16 17:22:20] tony2001@php.net >Why did you need to add tell() function to the streams internals? Because the original problem (stream_tell() is not used) looks like a bug to me. ------------------------------------------------------------------------ [2005-06-16 17:17:11] wez@php.net This tell patch (http://tony2001.phpclub.net/dev/tmp/userstreamop_tell.diff) is "wrong"; the position should be set implicitly when the stream is opened, and be updated by the streams layer when it knows that it is changed (as happens when you seek). If you need to determine the current position, you simply need to seek with a zero offset from the current position. Why did you need to add tell() function to the streams internals? ------------------------------------------------------------------------ [2005-06-16 00:54:11] tony2001@php.net Sara, IMO it's time to commit the patch into 5.1. What do you think? ------------------------------------------------------------------------ [2005-04-05 23:30:52] tony2001@php.net Seems that Wez doesn't have enough time to work on it anymore. Sara, plz, take a look at this patch: http://tony2001.phpclub.net/dev/tmp/userstreamop_tell.diff The only problem I can see there is that all custom stream wrapper will have to add appropriate entries too. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/30157 -- Edit this bug report at http://bugs.php.net/?id=30157&edit=1

« previous php.bugs (#99943) next »