Re: cvs: php4 /main main.c

I believe that this is fixed now in current CVS. --Wez. On 17/03/02, "Andi Gutmans" <andi@zend.com> wrote: > We need to make sure that this doesn't get forgotten though. Maybe open a > critical bug report for this. > > Andi > > At 01:50 PM 3/16/2002 +0000, Wez Furlong wrote: > >wez Sat Mar 16 08:50:17 2002 EDT > > > > Modified files: > > /php4/main main.c > > Log: > > work around apache segfault for the moment > > > >Index: php4/main/main.c > >diff -u php4/main/main.c:1.433 php4/main/main.c:1.434 > >--- php4/main/main.c:1.433 Fri Mar 15 20:58:13 2002 > >+++ php4/main/main.c Sat Mar 16 08:50:17 2002 > >@@ -18,7 +18,7 @@ > > +----------------------------------------------------------------------+ > > */ > > > >-/* $Id: main.c,v 1.433 2002/03/16 01:58:13 wez Exp $ */ > >+/* $Id: main.c,v 1.434 2002/03/16 13:50:17 wez Exp $ */ > > > > /* {{{ includes > > */ > >@@ -573,7 +573,8 @@ > > php_stream_sock_set_chunk_size(stream, 1); > > > > if (php_stream_cast(stream, PHP_STREAM_AS_STDIO | > > PHP_STREAM_CAST_TRY_HARD, (void**)&retval, 1) == SUCCESS) { > >- ZEND_REGISTER_RESOURCE(NULL, stream, > >php_file_le_stream()); > >+ /* The leak here prevents a segfault */ > >+ /* ZEND_REGISTER_RESOURCE(NULL, stream, > >php_file_le_stream()); */ > > } > > else { > > php_stream_close(stream); > > > > > > > >-- > >PHP CVS Mailing List (http://www.php.net/) > >To unsubscribe, visit: http://www.php.net/unsub.php