Re: cvs: php4 /main streams.c
| From: | Jon Parise | Date: | Sat, 16 Mar 2002 20:20:14 +0000 |
| Subject: | Re: cvs: php4 /main streams.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-10266@lists.php.net to get a copy of this message | ||
Sorry, I don't mean to single you out, Marcus.
> Modified files:
> /php4/main streams.c
> Log:
> -copy_stream_to_stream returns size if maxlen == PHP_STREAM_COPY_ALL
> #had to commit myself to do the rest...
This commit is 90% whitespace-related. Not only does that bloat
the repository unnecessarily, but it also requires the reviewer
to page through the diff to weed our your three-line (functional)
change.
Can everyone here please make an effort to type 'cvs diff' to
review their changes before committing code?
If you want to commit whitespace changes (and there's really no
need for them _ever_ if people would just learn how to configure
their editors and following the prescribed coding standards),
please do so as a separate commit.
--
Jon Parise (jon@csh.rit.edu) . Information Technology (2001)
http://www.csh.rit.edu/~jon/ : Computer Science House
Member