com php-src: Add \PDO::SQLITE_ATTR_READONLY_STATEME NT: ext/pdo_sqlite/pdo_sqlite.c ext/pdo_sqlite/ph p_pdo_sqlite_int.h
ext/pdo_sqlite/sqlite_statemen t.c ext/pdo_sqlite/tests/pdo_sqlite_statement_getat tribute.phpt

From: Date: Wed, 01 Aug 2018 21:45:20 +0000
Subject: com php-src: Add \PDO::SQLITE_ATTR_READONLY_STATEME NT: ext/pdo_sqlite/pdo_sqlite.c ext/pdo_sqlite/ph p_pdo_sqlite_int.h
ext/pdo_sqlite/sqlite_statemen t.c ext/pdo_sqlite/tests/pdo_sqlite_statement_getat tribute.phpt
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-102774@lists.php.net to get a copy of this message
Commit: 6f9ebe677bf31d0c64046f18e6b0ac75340cb93e Author: BohwaZ <bohwaz@users.noreply.github.com> Wed, 1 Aug 2018 17:45:20 -0400 Committer: Adam Baratz <adambaratz@php.net> Wed, 1 Aug 2018 17:45:20 -0400 Parents: 1a303f1a2b6ed8853fea3a2079999eef7f462d86 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6f9ebe677bf31d0c64046f18e6b0ac75340cb93e Log: Add \PDO::SQLITE_ATTR_READONLY_STATEMENT This attribute is a boolean value. It is taken from the return value of sqlite3_stmt_readonly(), indicating if and only if the prepared statement makes no direct changes to the content of the database. Changed paths: M ext/pdo_sqlite/pdo_sqlite.c M ext/pdo_sqlite/php_pdo_sqlite_int.h M ext/pdo_sqlite/sqlite_statement.c A ext/pdo_sqlite/tests/pdo_sqlite_statement_getattribute.phpt Diff: diff --git a/ext/pdo_sqlite/pdo_sqlite.c b/ext/pdo_sqlite/pdo_sqlite.c index 235191b..f91dd13 100644 --- a/ext/pdo_sqlite/pdo_sqlite.c +++ b/ext/pdo_sqlite/pdo_sqlite.c @@ -75,6 +75,7 @@ PHP_MINIT_FUNCTION(pdo_sqlite) REGISTER_PDO_CLASS_CONST_LONG("SQLITE_OPEN_READONLY", (zend_long)SQLITE_OPEN_READONLY); REGISTER_PDO_CLASS_CONST_LONG("SQLITE_OPEN_READWRITE", (zend_long)SQLITE_OPEN_READWRITE); REGISTER_PDO_CLASS_CONST_LONG("SQLITE_OPEN_CREATE", (zend_long)SQLITE_OPEN_CREATE); + REGISTER_PDO_CLASS_CONST_LONG("SQLITE_ATTR_READONLY_STATEMENT", (zend_long)PDO_SQLITE_ATTR_READONLY_STATEMENT); return php_pdo_register_driver(&pdo_sqlite_driver); } diff --git a/ext/pdo_sqlite/php_pdo_sqlite_int.h b/ext/pdo_sqlite/php_pdo_sqlite_int.h index 7e9a97c..2cd855e 100644 --- a/ext/pdo_sqlite/php_pdo_sqlite_int.h +++ b/ext/pdo_sqlite/php_pdo_sqlite_int.h @@ -76,6 +76,7 @@ extern const struct pdo_stmt_methods sqlite_stmt_methods; enum { PDO_SQLITE_ATTR_OPEN_FLAGS = PDO_ATTR_DRIVER_SPECIFIC, + PDO_SQLITE_ATTR_READONLY_STATEMENT }; #endif diff --git a/ext/pdo_sqlite/sqlite_statement.c b/ext/pdo_sqlite/sqlite_statement.c index c82e2d3..4a9d246 100644 --- a/ext/pdo_sqlite/sqlite_statement.c +++ b/ext/pdo_sqlite/sqlite_statement.c @@ -350,6 +350,28 @@ static int pdo_sqlite_stmt_cursor_closer(pdo_stmt_t *stmt) return 1; } +static int pdo_sqlite_stmt_get_attribute(pdo_stmt_t *stmt, zend_long attr, zval *val) +{ + pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data; + + switch (attr) { + case PDO_SQLITE_ATTR_READONLY_STATEMENT: + ZVAL_FALSE(val); + +#if SQLITE_VERSION_NUMBER >= 3007004 + if (sqlite3_stmt_readonly(S->stmt)) { + ZVAL_TRUE(val); + } +#endif + break; + + default: + return 0; + } + + return 1; +} + const struct pdo_stmt_methods sqlite_stmt_methods = { pdo_sqlite_stmt_dtor, pdo_sqlite_stmt_execute, @@ -358,7 +380,7 @@ const struct pdo_stmt_methods sqlite_stmt_methods = { pdo_sqlite_stmt_get_col, pdo_sqlite_stmt_param_hook, NULL, /* set_attr */ - NULL, /* get_attr */ + pdo_sqlite_stmt_get_attribute, /* get_attr */ pdo_sqlite_stmt_col_meta, NULL, /* next_rowset */ pdo_sqlite_stmt_cursor_closer diff --git a/ext/pdo_sqlite/tests/pdo_sqlite_statement_getattribute.phpt b/ext/pdo_sqlite/tests/pdo_sqlite_statement_getattribute.phpt new file mode 100644 index 0000000..559907c --- /dev/null +++ b/ext/pdo_sqlite/tests/pdo_sqlite_statement_getattribute.phpt @@ -0,0 +1,20 @@ +--TEST-- +PDO_sqlite: Testing PDOStatement::getAttribute() +--SKIPIF-- +<?php if (!extension_loaded('pdo_sqlite')) print 'skip not loaded'; ?> +--FILE-- +<?php + +$db = new PDO('sqlite::memory:'); + +$st = $db->prepare('SELECT 1;'); + +var_dump($st->getAttribute(PDO::SQLITE_ATTR_READONLY_STATEMENT)); + +$st = $db->prepare('CREATE TABLE test (a TEXT);'); + +var_dump($st->getAttribute(PDO::SQLITE_ATTR_READONLY_STATEMENT)); +?> +--EXPECTF-- +bool(true) +bool(false) \ No newline at end of file

« previous php.cvs (#102774) next »