Re: cvs: php4 /ext/standard var_unserializer.c var_unserializer.re

If this wasn't a bug it's probably better to do limit = NULL; so that if someone tries to understand this code later on they won't start wondering why limit is initialized to *p. It might mislead people. What do you think? Andi At 04:45 PM 3/17/2002 +0000, Harald Radi wrote:

phanto          Sun Mar 17 11:45:56 2002 EDT

Modified files:

    /php4/ext/standard  var_unserializer.c var_unserializer.re

Log: removed anoying warnings Index: php4/ext/standard/var_unserializer.c diff -u php4/ext/standard/var_unserializer.c:1.9 php4/ext/standard/var_unserializer.c:1.10

--- php4/ext/standard/var_unserializer.c:1.9    Tue Mar 12 15:17:56 2002
+++ php4/ext/standard/var_unserializer.c        Sun Mar 17 11:45:56 2002

@@ -220,7 +220,7 @@

        const unsigned char *cursor, *limit, *marker, *start;
        zval **rval_ref;

-       cursor = *p;
+       limit = cursor = *p;

        if (var_hash && cursor[0] != 'R') {
                var_push(var_hash, rval);

Index: php4/ext/standard/var_unserializer.re diff -u php4/ext/standard/var_unserializer.re:1.5 php4/ext/standard/var_unserializer.re:1.6 --- php4/ext/standard/var_unserializer.re:1.5 Tue Mar 12 15:17:57 2002

+++ php4/ext/standard/var_unserializer.re       Sun Mar 17 11:45:56 2002

@@ -222,7 +222,7 @@

        const unsigned char *cursor, *limit, *marker, *start;
        zval **rval_ref;

-       cursor = *p;
+       limit = cursor = *p;

        if (var_hash && cursor[0] != 'R') {
                var_push(var_hash, rval);

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php