Re: cvs: php4 /ext/bz2 bz2.c php_bz2.h /ext/zlib zlib_fopen_wrapper.c

Geez, that is what I am doing... The tests for bz2 succeed, so it must be OK. Could you verify that Sterling? --Wez. On 21/03/02, "Wez Furlong" <wez@thebrainroom.com> wrote: > On 21/03/02, "Sterling Hughes" <sterling@bumblebury.com> wrote: > > > Damn: I forgot to mention that I fixed the bz2 tests > > > by making sure that bzcompress bzdecompress NUL > > > terminate their strings. > > they shouldn't null terminate...its binary data (or can contain binary > > data). > > Ah. But I thought that all strings in zvals had to be nul terminated? > (Hence the warning during the tests). > > How about allowing for the nul but setting the size to not include it? > Would that work? > > > Btw, your work on streams ROCKS! ;))) > > Thanks! > > --Wez.