Re: cvs: php4 /ext/xslt config.m4

Why would a path contain spaces? :) But you're right, of course. Ask Sascha. --Jani On Thu, 21 Mar 2002, Markus Fischer wrote: > Shouldn't we always double quote strings passed to 'test' ? > What if the $i path contains a space ? > >On Thu, Mar 21, 2002 at 03:49:55PM -0000, Jani Taskinen wrote : >> sniper Thu Mar 21 10:49:55 2002 EDT >> >> Modified files: >> /php4/ext/xslt config.m4 >> Log: >> Minor detail fixed. >> >> Index: php4/ext/xslt/config.m4 >> diff -u php4/ext/xslt/config.m4:1.18 php4/ext/xslt/config.m4:1.19 >> --- php4/ext/xslt/config.m4:1.18 Sun Mar 17 16:09:21 2002 >> +++ php4/ext/xslt/config.m4 Thu Mar 21 10:49:54 2002 >> @@ -1,5 +1,5 @@ >> dnl >> -dnl $Id: config.m4,v 1.18 2002/03/17 21:09:21 sniper Exp $ >> +dnl $Id: config.m4,v 1.19 2002/03/21 15:49:54 sniper Exp $ >> dnl >> dnl +------------------------------------------------------------------------------+ >> dnl | This is where the magic of the extension reallly is. Depending on what | >> @@ -56,7 +56,7 @@ >> if test "$PHP_XSLT_SABLOT" != "no"; then >> found_expat=no >> for i in $PHP_EXPAT_DIR $XSLT_DIR; do >> - if test -f $i/lib/libexpat.a -o -f $i/lib/libexpat.so; then >> + if test -f $i/lib/libexpat.a -o -f $i/lib/libexpat.$SHLIB_SUFFIX_NAME; then >> AC_DEFINE(HAVE_LIBEXPAT2, 1, [ ]) >> PHP_ADD_INCLUDE($i/include) >> PHP_ADD_LIBRARY_WITH_PATH(expat, $i/lib, XSLT_SHARED_LIBADD) >> >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php > > --