Re: com php-src: Implement mb_str_split(): UPGRADING ext/mbstring/mbstring.c ext/mbstring/mbstring.h ext/mbstring/tests/mb_str_split_jp.phpt
ext/mbstring/tests/mb_str_split_ru.phpt ext/mbstring/tests/mb_str_split_utf8_utf16.phpt
| From: | Matteo Beccati | Date: | Fri, 29 Mar 2019 13:00:44 +0000 |
| Subject: | Re: com php-src: Implement mb_str_split(): UPGRADING ext/mbstring/mbstring.c ext/mbstring/mbstring.h ext/mbstring/tests/mb_str_split_jp.phpt ext/mbstring/tests/mb_str_split_ru.phpt ext/mbstring/tests/mb_str_split_utf8_utf16.phpt |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-105397@lists.php.net to get a copy of this message | ||
Hi Nikita,
I'm finally starting to catch up with some OSS work, including my CI for PHP nightly builds and tests w/ a few popular applications.
The CI runs on an Ubuntu Trusty box with gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4, which isn't able to properly build 7.4 because of:
In function ‘zif_mb_str_split’:
.../ext/mbstring/mbstring.c:2370:4: error: ‘for’ loop initial declarations are only allowed in C99 mode
Master however builds just fine, due to -std=gnu99 being used.
Cheers
On 12/02/2019 16:42, Nikita Popov wrote:
-- Matteo Beccati Development & Consulting - http://www.beccati.com/Commit: d77ad27415a34e4f5908cb262567b7b6f0eca17f Author: legale <legale.legale@gmail.com> Sat, 9 Feb 2019 20:27:48 +0100 Committer: Nikita Popov <nikita.ppv@gmail.com> Tue, 12 Feb 2019 16:42:51 +0100Parents: 083cfc07cc13b1804ceeaa61f44319c598c05670 Branches: PHP-7.4 masterLink: http://git.php.net/?p=php-src.git;a=commitdiff;h=d77ad27415a34e4f5908cb262567b7b6f0eca17fLog: Implement mb_str_split() RFC: https://wiki.php.net/rfc/mb_str_split Changed paths: M UPGRADING M ext/mbstring/mbstring.c M ext/mbstring/mbstring.h A ext/mbstring/tests/mb_str_split_jp.phpt A ext/mbstring/tests/mb_str_split_ru.phpt A ext/mbstring/tests/mb_str_split_utf8_utf16.phpt