Re: cvs: php4 /ext/bz2 bz2.c /ext/standard php_fopen_wrapper.c /ext/zlib zlib_fopen_wrapper.c /main streams.c

Hello, I added this NEWS entry. Derick On Thu, 21 Mar 2002, Markus Fischer wrote: > On Thu, Mar 21, 2002 at 05:02:50PM -0000, Wez Furlong wrote : > > wez Thu Mar 21 12:02:50 2002 EDT > > > > Modified files: > > /php4/ext/bz2 bz2.c > > /php4/ext/standard php_fopen_wrapper.c > > /php4/ext/zlib zlib_fopen_wrapper.c > > /php4/main streams.c > > Log: > > Require that wrappers use <protocol>://<path> to avoid > > ambiguities when filenames have ':' characters. > > > > This slightly breaks BC with the old style zlib: wrapper. > > I think it's actually not slightly but a major BC. Should > deserve a hint in the NEWS entry and big outlined in the > documentation if it now stays this way. > > > > > > Index: php4/ext/bz2/bz2.c > > diff -u php4/ext/bz2/bz2.c:1.41 php4/ext/bz2/bz2.c:1.42 > > --- php4/ext/bz2/bz2.c:1.41 Thu Mar 21 11:51:01 2002 > > +++ php4/ext/bz2/bz2.c Thu Mar 21 12:02:44 2002 > > @@ -16,7 +16,7 @@ > > +----------------------------------------------------------------------+ > > */ > > > > -/* $Id: bz2.c,v 1.41 2002/03/21 16:51:01 sterling Exp $ */ > > +/* $Id: bz2.c,v 1.42 2002/03/21 17:02:44 wez Exp $ */ > > > > #ifdef HAVE_CONFIG_H > > #include "config.h" > > @@ -161,8 +161,8 @@ > > char *path_copy; > > BZFILE *bz_file; > > > > - if (strncmp("bz2:", path, 4) == 0) > > - path += 4; > > + if (strncasecmp("bz2://", path, 6) == 0) > > + path += 6; > > Just curious, shouldn't that be 'bzip2' for correctness? > > -- > Please always Cc to me when replying to me on the lists. > GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > ----------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net -----------------------------------------------------------------------