com php-src: Add extensions naming conventions to ext_skel. php: ext/ext_skel.php
| From: | Peter Kokot | Date: | Tue, 14 May 2019 01:04:40 +0000 |
| Subject: | com php-src: Add extensions naming conventions to ext_skel. php: ext/ext_skel.php | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-106172@lists.php.net to get a copy of this message | ||
Commit: 44952cd9d4e39cb3b0cf58b33e4d860b346cdc91
Author: Peter Kokot <peterkokot@gmail.com> Sun, 12 May 2019 20:39:42 +0200
Parents: 63e43e19ea3f47cfbc28b02d0df3f0255d3d2309
Branches: PHP-7.4 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=44952cd9d4e39cb3b0cf58b33e4d860b346cdc91
Log:
Add extensions naming conventions to ext_skel.php
- first character is a letter
- followed by any number of letters, numbers, or underscores
- prefferred are lower case letters
Changed paths:
M ext/ext_skel.php
Diff:
diff --git a/ext/ext_skel.php b/ext/ext_skel.php
index 4623910..2b800ca 100755
--- a/ext/ext_skel.php
+++ b/ext/ext_skel.php
@@ -226,6 +226,13 @@ function process_args($argv, $argc) {
error('The skeleton directory was not found');
}
+ // Validate extension name
+ if (!preg_match('/^[a-z][a-z0-9_]+$/i', $options['ext'])) {
+ error('Invalid extension name. Valid names start with a letter,'
+ .' followed by any number of letters, numbers, or underscores.'
+ .' Using only lower case letters is preferred.');
+ }
+
$options['ext'] = str_replace(['\\', '/'], '',
strtolower($options['ext']));
return $options;