Re: com php-src: Make chr ZPP failure message consistentwith ext/standard:
ext/standard/string.cext/standard/tests/array/array_filter_variation9.phptext/standard/tests/strings/chr_error.phptext/standard/tests/strings/chr_ord.phptext/standard/tests/strings/chr_variation1.phpt

From: Date: Sun, 19 May 2019 10:27:22 +0000
Subject: Re: com php-src: Make chr ZPP failure message consistentwith ext/standard:
ext/standard/string.cext/standard/tests/array/array_filter_variation9.phptext/standard/tests/strings/chr_error.phptext/standard/tests/strings/chr_ord.phptext/standard/tests/strings/chr_variation1.phpt
References: 1 2 3 4  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-106241@lists.php.net to get a copy of this message
Hello Matteo, Em dom, 19 de mai de 2019 às 06:22, Matteo Beccati <php@beccati.com> escreveu: > On 19/05/2019 10:57, Christoph M. Becker wrote: > > On 19.05.2019 at 08:58, Matteo Beccati wrote: > > > >> I have 3 new chr/ord related tests failing this morning on master. I > >> suspect they are related to this commit: > >> > >> https://revive.beccati.com/bamboo/browse/PHP-SRC-1953/testŒªãE¾w âÀQ# > >> §ª Yes, looks like I mess up during some conflicts. Here's the original PR: https://github.com/php/php-src/pull/4080. > > > > > Looks like some test case changes did not make it into master: > > > > < > > http://git.php.net/?p=php-src.git;a=commit;h=714d9fc358640069bda5540c2b1136a6241c4c94 > > > > > > vs. > > > > < > > http://git.php.net/?p=php-src.git;a=commit;h=a437f065b87c5b440152d6de1d0ec01034030dfe > > > > Indeed. I'm pushing these changes to master. Thanks for catching this and sorry for the noise :) > Yep, and ext/standard/tests/strings/chr_ord.phpt was possibly deleted by > mistake on 7.4? > I remove this test in specific as per https://externals.io/message/103886. Best, > > Cheers > -- > Matteo Beccati > > Development & Consulting - http://www.beccati.com/ >

« previous php.cvs (#106241) next »