Re: cvs: php4 /ext/exif exif.c

On Fri, 5 Apr 2002, Marcus Börger wrote: > helly Thu Apr 4 20:25:54 2002 EDT > > Modified files: > /php4/ext/exif exif.c > Log: > Unicode is now based on php_mb_convert_encoding if available > #currently only ISO-8859-15 is supported as result > #maybe this will become an ini setting > > Index: php4/ext/exif/exif.c > diff -u php4/ext/exif/exif.c:1.82 php4/ext/exif/exif.c:1.83 > --- php4/ext/exif/exif.c:1.82 Thu Apr 4 15:45:53 2002 > +++ php4/ext/exif/exif.c Thu Apr 4 20:25:53 2002 > @@ -913,6 +917,7 @@ > int motorola_intel; /* 1 Motorola; 0 Intel */ > > char *UserComment; > + int UserCommentLength; Tabsettings? :) > @@ -1983,17 +2025,30 @@ > > /* {{{ exif_process_user_comment > * Process UserComment in IFD. */ > -static int exif_process_user_comment(char **pszInfoPtr,char **szEncoding,char *szValuePtr,int > ByteCount) > +static int exif_process_user_comment(char **pszInfoPtr, char **szEncoding, char *szValuePtr, > int ByteCount, int motorola_intel TSRMLS_DC) > { > int a; > > + #ifdef HAVE_MBSTRING > + size_t len;; > + #endif Not aligning the # on the first column may break compilers/preprocessors on odd systems, it's also hard to spot. Can you please do it like this: #ifdef HAVE_MBSTRING size_t len; #endif Derick ----------------------------------------------------------------------- Did I help you? Consider a gift: http://www.amazon.co.uk/exec/obidos/registry/SLCB276UZU8B ----------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net -----------------------------------------------------------------------