cvs: php4 /sapi/apache2filter sapi_apache2.c
| From: | Aaron Bannert | Date: | Tue, 16 Apr 2002 17:41:34 +0000 |
| Subject: | cvs: php4 /sapi/apache2filter sapi_apache2.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-11169@lists.php.net to get a copy of this message | ||
aaron Tue Apr 16 13:41:34 2002 EDT
Modified files:
/php4/sapi/apache2filter sapi_apache2.c
Log:
It makes more sense to do the null-pointer check *before* trying to use it.
(Also fix a typo that Cliff pointed out: "safe" --> "save".)
Obtained from: Ryan Morgan <rmorgan@covalent.net>
Index: php4/sapi/apache2filter/sapi_apache2.c
diff -u php4/sapi/apache2filter/sapi_apache2.c:1.70 php4/sapi/apache2filter/sapi_apache2.c:1.71
--- php4/sapi/apache2filter/sapi_apache2.c:1.70 Sun Apr 14 08:38:33 2002
+++ php4/sapi/apache2filter/sapi_apache2.c Tue Apr 16 13:41:28 2002
@@ -346,12 +346,12 @@
ap_add_cgi_vars(f->r);
ctx = SG(server_context);
- ctx->f = f; /* safe whatever filters are after us in the chain. */
if (ctx == NULL) {
ap_log_rerror(APLOG_MARK, APLOG_ERR|APLOG_NOERRNO, 0, f->r,
"php failed to get server context");
return HTTP_INTERNAL_SERVER_ERROR;
}
+ ctx->f = f; /* save whatever filters are after us in the chain. */
if (ctx->request_processed) {
return ap_pass_brigade(f->next, bb);