cvs: php4 /ext/pgsql pgsql.c
| From: | Yasuo Ohgaki | Date: | Fri, 19 Apr 2002 12:19:33 +0000 |
| Subject: | cvs: php4 /ext/pgsql pgsql.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-11231@lists.php.net to get a copy of this message | ||
yohgaki Fri Apr 19 08:19:33 2002 EDT
Modified files:
/php4/ext/pgsql pgsql.c
Log:
Changed "default" -> "has default" (metadata)
Fixed comment. Do not use magic number.
Index: php4/ext/pgsql/pgsql.c
diff -u php4/ext/pgsql/pgsql.c:1.177 php4/ext/pgsql/pgsql.c:1.178
--- php4/ext/pgsql/pgsql.c:1.177 Fri Apr 19 03:47:53 2002
+++ php4/ext/pgsql/pgsql.c Fri Apr 19 08:19:29 2002
@@ -19,7 +19,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: pgsql.c,v 1.177 2002/04/19 07:47:53 yohgaki Exp $ */
+/* $Id: pgsql.c,v 1.178 2002/04/19 12:19:29 yohgaki Exp $ */
#include <stdlib.h>
@@ -2764,10 +2764,10 @@
add_assoc_bool(elem, "not null", 0);
}
if (!strcmp(PQgetvalue(pg_result,i,5), "t")) {
- add_assoc_bool(elem, "default", 1);
+ add_assoc_bool(elem, "has default", 1);
}
else {
- add_assoc_bool(elem, "default", 0);
+ add_assoc_bool(elem, "has default", 0);
}
name = PQgetvalue(pg_result,i,0);
add_assoc_zval(meta, name, elem);
@@ -2940,7 +2940,7 @@
/* }}} */
-/* {{{ php_pgsql_convert_add_quote
+/* {{{ php_pgsql_add_quote
* add quotes around string.
*/
static int php_pgsql_add_quotes(zval *src, zend_bool should_free TSRMLS_DC)
@@ -3580,6 +3580,8 @@
}
/* }}} */
+#define MAX_LENGTH_OF_LONG 30
+#define MAX_LENGTH_OF_DOUBLE 60
/* {{{ php_pgsql_insert
*/
@@ -3629,10 +3631,10 @@
values_len += Z_STRLEN_PP(val);
break;
case IS_LONG:
- values_len += 30;
+ values_len += MAX_LENGTH_OF_LONG;
break;
case IS_DOUBLE:
- values_len += 60;
+ values_len += MAX_LENGTH_OF_DOUBLE;
break;
default:
if (convert) {