com php-src: Mention that an API bump must be done with RC1: docs/release-process.md
| From: | Derick Rethans | Date: | Mon, 27 Jul 2020 13:19:21 +0000 |
| Subject: | com php-src: Mention that an API bump must be done with RC1: docs/release-process.md | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-112379@lists.php.net to get a copy of this message | ||
Commit: d66a6ba58a007737e0ab43c3a433007f57bfa035
Author: Derick Rethans <github@derickrethans.nl> Mon, 27 Jul 2020 14:15:06 +0100
Parents: 54e15dcd6f43625b2789895c892df436d393fb9c
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=d66a6ba58a007737e0ab43c3a433007f57bfa035
Log:
Mention that an API bump must be done with RC1
It's okay to change the API change up until the first release candidate only,
and it may not be changed afterwards.
There is a discussion at https://github.com/php/php-src/pull/4470/files
that
never resulted in a fix.
/cc @sgolemon @carusogabriel
Changed paths:
M docs/release-process.md
Diff:
diff --git a/docs/release-process.md b/docs/release-process.md
index 3a9bebe68f..50acab03fe 100644
--- a/docs/release-process.md
+++ b/docs/release-process.md
@@ -93,11 +93,12 @@
beta. Do not use dashes, you should
#define PHP_VERSION "7.4.22RC1" and
not #define PHP_VERSION "7.4.22-RC1".
- When releasing the first alpha version, bump also API version numbers in
- Zend/zend_extensions.h, Zend/zend_modules.h, and
main/php.h. The API
- versions between the alpha/beta/.0RCx releases can be left the same or
- bumped as little as possible because PHP extensions will need to be rebuilt
- with each bump.
+ When releasing the first release candidate, you must also bump the API
+ version numbers in Zend/zend_extensions.h, Zend/zend_modules.h, and
+ main/php.h. The API versions between the alpha/beta/.0RCx releases can be
+ left the same, or bumped as little as possible because PHP extensions will
+ need to be rebuilt with each bump. Do *not* bump the API versions after
+ RC1.
6. Compile and run make test, with and without ZTS, using the right Bison and
re2c version (for PHP 7.4, minimum Bison 3.0.0 and re2c 0.13.4 are used).