Re: cvs: php4 /ext/standard url_scanner_ex.re

On Sat, May 04, 2002 at 05:14:56PM -0000, Sascha Schumann wrote: > sas Sat May 4 13:14:56 2002 EDT > > Modified files: > /php4/ext/standard url_scanner_ex.re > Log: > include url.h to pull in declaration of php_url_encode > > > Index: php4/ext/standard/url_scanner_ex.re > diff -u php4/ext/standard/url_scanner_ex.re:1.52 php4/ext/standard/url_scanner_ex.re:1.53 > --- php4/ext/standard/url_scanner_ex.re:1.52 Fri May 3 04:00:40 2002 > +++ php4/ext/standard/url_scanner_ex.re Sat May 4 13:14:56 2002 > @@ -30,6 +30,7 @@ > #include "php_globals.h" > #define STATE_TAG SOME_OTHER_STATE_TAG > #include "basic_functions.h" > +#include "url.h" > #undef STATE_TAG > > #define url_scanner url_scanner_ex > @@ -421,13 +422,13 @@ > zend_hash_init(BG(url_adapt_state_ex).rewrite_vars, 0, NULL, (void (*)(void *)) > php_url_scanner_var_dtor, 0); > } > > - smart_str_setl(&(var.var), estrndup(name, name_len), name_len); > + smart_str_appendl(&(var.var), name, name_len); i do think we need to copy here. was taking it out done by intention? tc > > if (urlencode) { > encoded = php_url_encode(value, value_len, &encoded_len); > smart_str_setl(&(var.val), encoded, encoded_len); > } else { > - smart_str_setl(&(var.val), estrndup(value, value_len), value_len); > + smart_str_appendl(&(var.val), value, value_len); > } > > return zend_hash_add(BG(url_adapt_state_ex).rewrite_vars, name, name_len, &var, > sizeof(url_adapt_var_t), NULL); > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php