Re: cvs: php4 /main output.c

Zeev Suraski wrote:

zeev Sat May 4 19:23:16 2002 EDT

  Modified files:                  /php4/main	output.c   Log:

We shouldn't force Content-length:, but much worse, it's wrong in many cases (basically, unless you use output buffering to buffer all of your content, it won't work; output buffering is used for lots of different things as a functional interface, and such buffers have no relation to Content-type at all).

It only sends Content-Length when it is possible. Whole content fits in buffer(chunk) AND Buffer is not erasable (prevent CL for temp buffer use in script) AND Header is not sent yet (prevent header already sent error) AND The buffer is nest level 1 (the buffer is the last buffer to sent. Prevent bogus CL header sent.) If user is using zlib.output_compression=4096 and output_buffering=4096, most output may have Content-Length header since text is compressed. (Or have zlib.output_compression=40960, for exmaple) I think it's reasonable for some usage. Am I missing something? BTW, I think users should have different server for linked objects such as images, css, js, etc. So I don't mind at all removing the feature. We need to delete a few more lines from CVS such as NEWS. It saves my time to document implication of larger chunk size (slower reponse time), CL header, etc. Any comments? (No comments with in a few days => I'll clean up :) -- Yasuo Ohgaki