RE: [PHP-CVS] cvs: php4 /main php_open_temporary_file.c

Misread the CODING_STANDARDS it seems. [4] When indenting, use the tab character. A tab is expected to represent four spaces. It is important to maintain consistency in indenture so that definitions, comments, and control structures line up correctly. Read this to mean tabs should be *expanded* to 4 spaces (a not-unusual requirement) so that's how the editor is set. Too many projects with too many different standards :). I *always* run "cvs diff" before committing, and have "diff -u -b" in .cvsrc (also in the PHP recommendations) - so I don't see changes in whitespace from tab/space translation. I'll change the editor settings... > -----Original Message----- > From: Rasmus Lerdorf [mailto:rasmus@php.net] > Sent: Thursday, May 09, 2002 12:41 PM > To: Preston L. Bannister > Cc: php-cvs@lists.php.net > Subject: Re: [PHP-CVS] cvs: php4 /main php_open_temporary_file.c > > > Could you try not to mix whitespace changes with code changes? It is > really hard to pick out what you actually changed with all the whitespace > changes. > > Do a cvs diff before you commit to make sure the diff is nice and clean > and it is easy to see the important change. If you feel the need to make > whitespace changes, please do so in a separate patch, but please keep such > changes to an absolute minimum as it makes multi-version spanning diffs > much harder to read. [snip]