Re: cvs: php4(PHP_4_2_0) /ext/mcal config.m4

On Mon, 24 Jun 2002, Jani Taskinen wrote: > > And what was the 2nd line on my email? :) Yeah sure... have fun fixing that shitnitz :D Derick > On Mon, 24 Jun 2002 derick@php.net wrote: > > >On Mon, 24 Jun 2002, Jani Taskinen wrote: > > > >> > >> Did you _test_ this before committing it? > >> The real fix would be to fix PHP_ADD_LIBRARY_DEFER_WITH_PATH.. > > > >I didn't but Troels did: > > > >I need the following patch for the mcal extension to build properly as a > >shared module on my Linuxes: > > > > >>http://rpms.arvin.dk/php/source/patches/php-4.2.1-mcal-shared.patch > > > >It reverts a change made by sniper on April 3. Without the patch, then the > >main PHP binary links to libmcal.so.0, but the PHP extension (mcal.so) > >doesn't. > > > > > >Derick > > > >> On Mon, 24 Jun 2002, Derick Rethans wrote: > >> > >> >derick Mon Jun 24 04:44:41 2002 EDT > >> > > >> > Modified files: (Branch: PHP_4_2_0) > >> > /php4/ext/mcal config.m4 > >> > Log: > >> > - Fix building a shared extension (patch by Troels Arvin > >> > <troels@arvin.dk>) > >> > > >> > > >> >Index: php4/ext/mcal/config.m4 > >> >diff -u php4/ext/mcal/config.m4:1.11.2.1 php4/ext/mcal/config.m4:1.11.2.2 > >> >--- php4/ext/mcal/config.m4:1.11.2.1 Wed Apr 3 18:04:44 2002 > >> >+++ php4/ext/mcal/config.m4 Mon Jun 24 04:44:41 2002 > >> >@@ -1,5 +1,5 @@ > >> > dnl > >> >-dnl $Id: config.m4,v 1.11.2.1 2002/04/03 23:04:44 sniper Exp $ > >> >+dnl $Id: config.m4,v 1.11.2.2 2002/06/24 08:44:41 derick Exp $ > >> > dnl > >> > > >> > PHP_ARG_WITH(mcal,for MCAL support, > >> >@@ -42,7 +42,7 @@ > >> > fi > >> > > >> > PHP_ADD_INCLUDE($MCAL_INCLUDE) > >> >- PHP_ADD_LIBRARY_DEFER_WITH_PATH(mcal, $MCAL_LIBRARY, MCAL_SHARED_LIBADD) > >> >+ PHP_ADD_LIBRARY_WITH_PATH(mcal, $MCAL_LIBRARY, MCAL_SHARED_LIBADD) > >> > PHP_SUBST(MCAL_SHARED_LIBADD) > >> > AC_DEFINE(HAVE_MCAL,1,[ ]) > >> > PHP_EXTENSION(mcal,$ext_shared) > >> > > >> > > >> > > >> > > >> > >> -- > >> > > > >--------------------------------------------------------------------------- > > Did I help you? > > http://www.derickrethans.nl/link.php?url=giftlist > > Frequent ranting: http://www.derickrethans.nl/ > >--------------------------------------------------------------------------- > > PHP: Scripting the Web - derick@php.net > > All your branches are belong to me! > > SRM: Script Running Machine - www.vl-srm.net > >--------------------------------------------------------------------------- > > > > > > > > -- > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --------------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net ---------------------------------------------------------------------------