Re: cvs: php4 /ext/dio dio.c

> Are you sure the length should be strlen("string") and not > strlen("string")+1? In any case, this kind of code should use > sizeof("type") and not numbers which is extremely prone to error. > Sterling, how did you write such ugly code :P > Shame on you! ;) > hehe... :) sizeof () looks right. It was on a train in germany, battery power must of been running out (best excuse I could think of ;)) -Sterling > Andi > > At 07:34 PM 7/5/2002 +0000, Jani Taskinen wrote: >>sniper Fri Jul 5 15:34:43 2002 EDT >> >> Modified files: >> /php4/ext/dio dio.c >> Log: >> Fix bug: #16707 >> >> >>Index: php4/ext/dio/dio.c >>diff -u php4/ext/dio/dio.c:1.12 php4/ext/dio/dio.c:1.13 >>--- php4/ext/dio/dio.c:1.12 Sun Jun 9 08:56:27 2002 >>+++ php4/ext/dio/dio.c Fri Jul 5 15:34:42 2002 >>@@ -346,10 +346,10 @@ >> lk.l_whence = 0; >> } >> else { >>- lk.l_whence = SEEK_SET; >>+ lk.l_whence = Z_LVAL_PP(element); >> } >> >>- if (zend_hash_find(fh, "type", 6, (void **) >>&element) == FAILURE) { >>+ if (zend_hash_find(fh, "type", 4, (void **) >>&element) == FAILURE) { >> lk.l_type = 0; >> } >> else { >> >> >> >>-- >>PHP CVS Mailing List (http://www.php.net/) >>To unsubscribe, visit: http://www.php.net/unsub.php > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php