[php-src] master: Fix implicitly marking parameter as nullable deprecation warning (#13714)
| From: | Peter Kokot via GitHub | Date: | Thu, 14 Mar 2024 21:05:44 +0000 |
| Subject: | [php-src] master: Fix implicitly marking parameter as nullable deprecation warning (#13714) | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-127740@lists.php.net to get a copy of this message | ||
Author: Peter Kokot (petk)
Committer: GitHub (web-flow)
Pusher: petk
Date: 2024-03-14T21:51:55+01:00
Commit: https://github.com/php/php-src/commit/ec394cc26ade8a360a0c089e748bff48b516a215
Raw diff: https://github.com/php/php-src/commit/ec394cc26ade8a360a0c089e748bff48b516a215.diff
Fix implicitly marking parameter as nullable deprecation warning (#13714)
A follow up around the php-src code regarding the RFC:
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Changed paths:
M ext/phar/phar/pharcommand.inc
Diff:
diff --git a/ext/phar/phar/pharcommand.inc b/ext/phar/phar/pharcommand.inc
index 17c5c6051fafe..fee6c069ab085 100644
--- a/ext/phar/phar/pharcommand.inc
+++ b/ext/phar/phar/pharcommand.inc
@@ -630,15 +630,15 @@ class PharCommand extends CLICommand
* This function will take a directory and iterate through
* it and get the files to insert into the Phar archive.
*
- * @param Phar $phar The phar object.
- * @param string $input The input directory
- * @param string $regex The regex used in RegexIterator.
- * @param string $invregex The InvertedRegexIterator expression.
- * @param SplFileInfo $stub Stub file object
- * @param mixed $compress Compression algorithm or NULL
- * @param boolean $noloader Whether to prevent adding the loader
- */
- static function phar_add(Phar $phar, $level, $input, $regex, $invregex, SplFileInfo $stub =
NULL, $compress = NULL, $noloader = false)
+ * @param Phar $phar The phar object.
+ * @param string $input The input directory
+ * @param string $regex The regex used in RegexIterator.
+ * @param string $invregex The InvertedRegexIterator expression.
+ * @param ?SplFileInfo $stub Stub file object
+ * @param mixed $compress Compression algorithm or NULL
+ * @param boolean $noloader Whether to prevent adding the loader
+ */
+ static function phar_add(Phar $phar, $level, $input, $regex, $invregex, ?SplFileInfo $stub,
$compress = NULL, $noloader = false)
{
if ($input && is_file($input) && !is_dir($input)) {
return self::phar_add_file($phar, $level, $input, $input, $compress);