[php-src] master: Fix PdoSqlite::loadExtension() test (#13736)

From: Date: Sun, 17 Mar 2024 21:40:58 +0000
Subject: [php-src] master: Fix PdoSqlite::loadExtension() test (#13736)
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-127763@lists.php.net to get a copy of this message
Author: Nikita Popov (nikic) Committer: GitHub (web-flow) Pusher: kocsismate Date: 2024-03-17T22:27:09+01:00 Commit: https://github.com/php/php-src/commit/67184f54454db106aa66cc1787ddf753063af857 Raw diff: https://github.com/php/php-src/commit/67184f54454db106aa66cc1787ddf753063af857.diff Fix PdoSqlite::loadExtension() test (#13736) The test contained a syntax error and an incorrect use of loadExtension(), which returns void not bool. Also install the necessary package in CI, so it gets tested there. Changed paths: M .github/actions/apt-x64/action.yml M ext/pdo_sqlite/tests/subclasses/pdosqlite_003.phpt Diff: diff --git a/.github/actions/apt-x64/action.yml b/.github/actions/apt-x64/action.yml index 1a45bcc39d3ed..05e17918f015b 100644 --- a/.github/actions/apt-x64/action.yml +++ b/.github/actions/apt-x64/action.yml @@ -37,6 +37,7 @@ runs: libxpm-dev \ libzip-dev \ libsqlite3-dev \ + libsqlite3-mod-spatialite \ libwebp-dev \ libonig-dev \ libkrb5-dev \ diff --git a/ext/pdo_sqlite/tests/subclasses/pdosqlite_003.phpt b/ext/pdo_sqlite/tests/subclasses/pdosqlite_003.phpt index 860848dcff867..147999ae73bd4 100644 --- a/ext/pdo_sqlite/tests/subclasses/pdosqlite_003.phpt +++ b/ext/pdo_sqlite/tests/subclasses/pdosqlite_003.phpt @@ -28,11 +28,7 @@ if (!$db instanceof PdoSqlite) { echo "Wrong class type. Should be PdoSqlite but is " . get_class($db) . "\n"; } -$result = $db->loadExtension(getSpatialiteExtensionLocation();); -if ($result !== true) { - echo "Failed to load extension mod_spatialite.so"; - exit(-1); -} +$db->loadExtension(getSpatialiteExtensionLocation()); $result = $db->query('SELECT AsText(Buffer(GeomFromText("LINESTRING(0 0, 1 0)"), 0.2)) as geometry_data;');

« previous php.cvs (#127763) next »