[php-src] PHP-8.3: Fix ASan build
| From: | Ilija Tovilo | Date: | Tue, 19 Mar 2024 16:31:24 +0000 |
| Subject: | [php-src] PHP-8.3: Fix ASan build | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-127794@lists.php.net to get a copy of this message | ||
Author: Ilija Tovilo (iluuu1994)
Date: 2024-03-19T17:15:36+01:00
Commit: https://github.com/php/php-src/commit/697d1a1c637ff11844f409fc1f3c450def883f7b
Raw diff: https://github.com/php/php-src/commit/697d1a1c637ff11844f409fc1f3c450def883f7b.diff
Fix ASan build
See https://github.com/actions/runner-images/issues/9491#issuecomment-1989718917
The mentioned workaround doesn't work for us because we run ASan inside Docker.
Instead, we switch to ubuntu-20.04 as the host. The docker setup itself remains
the same.
Closes GH-13757
Changed paths:
M .github/workflows/push.yml
Diff:
diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
index eb8c4929a1305..58e32a2a847a3 100644
--- a/.github/workflows/push.yml
+++ b/.github/workflows/push.yml
@@ -72,7 +72,7 @@ jobs:
zts: true
asan: true
name: "LINUX_X64_${{ matrix.debug && 'DEBUG' || 'RELEASE'
}}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan &&
'_ASAN' || '' }}"
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-${{ !matrix.asan && '22' || '20' }}.04
container:
image: ${{ matrix.asan && 'ubuntu:23.04' || null }}
steps: