[php-src] master: Include the source location in Closure names (#13550)
| From: | Tim Düsterhus via GitHub | Date: | Fri, 12 Apr 2024 16:21:20 +0000 |
| Subject: | [php-src] master: Include the source location in Closure names (#13550) | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-128086@lists.php.net to get a copy of this message | ||
Author: Tim Düsterhus (TimWolla)
Committer: GitHub (web-flow)
Pusher: TimWolla
Date: 2024-04-12T18:21:13+02:00
Commit: https://github.com/php/php-src/commit/08b2ab22f4d3f26345e34d8fad9185f349dac43a
Raw diff: https://github.com/php/php-src/commit/08b2ab22f4d3f26345e34d8fad9185f349dac43a.diff
Include the source location in Closure names (#13550)
* Include the source location in Closure names
This change makes stack traces involving Closures, especially multiple
different Closures, much more useful, because it's more easily visible *which*
closure was called for a given stack frame.
The implementation is similar to that of anonymous classes which already
include the file name and line number within their generated classname.
* Update scripts/dev/bless_tests.php for closure naming
* Adjust existing tests for closure naming
* Adjust tests for closure naming that were not caught locally
* Drop the namespace from closure names
This is redundant with the included filename.
* Include filename and line number as separate keys in Closure debug info
* Fix test
* Fix test
* Include the surrounding class and function name in closure names
* Fix test
* Relax test expecations
* Fix tests after merge
* NEWS / UPGRADING
Changed paths:
A Zend/tests/closure_064.phpt
A Zend/tests/closure_065.phpt
A Zend/tests/closure_066.phpt
M NEWS
M UPGRADING
M Zend/tests/arrow_functions/006.phpt
M Zend/tests/bug26697.phpt
M Zend/tests/bug31102.phpt
M Zend/tests/bug49908.phpt
M Zend/tests/bug52193.phpt
M Zend/tests/bug60738.phpt
M Zend/tests/bug60738_variation.phpt
M Zend/tests/bug60909_1.phpt
M Zend/tests/bug61273.phpt
M Zend/tests/bug61767.phpt
M Zend/tests/bug64960.phpt
M Zend/tests/bug67856.phpt
M Zend/tests/bug70321.phpt
M Zend/tests/bug72101.phpt
M Zend/tests/bug74164.phpt
M Zend/tests/bug75079_2.phpt
M Zend/tests/bug75290.phpt
M Zend/tests/bug76534.phpt
M Zend/tests/bug79657.phpt
M Zend/tests/bug79778.phpt
M Zend/tests/bug81076.phpt
M Zend/tests/call_user_func_003.phpt
M Zend/tests/call_user_func_005.phpt
M Zend/tests/closure_005.phpt
M Zend/tests/closure_019.phpt
M Zend/tests/closure_020.phpt
M Zend/tests/closure_026.phpt
M Zend/tests/closure_027.phpt
M Zend/tests/closure_032.phpt
M Zend/tests/closure_033.phpt
M Zend/tests/closure_034.phpt
M Zend/tests/closure_035.phpt
M Zend/tests/closure_038.phpt
M Zend/tests/closure_039.phpt
M Zend/tests/closure_059.phpt
M Zend/tests/deprecation_to_exception_during_inheritance.phpt
M Zend/tests/exception_023.phpt
M Zend/tests/exception_during_variance_autoload.phpt
M Zend/tests/exception_during_variance_autoload_2.phpt
M Zend/tests/exception_ignore_args.phpt
M Zend/tests/fibers/backtrace-deep-nesting.phpt
M Zend/tests/fibers/backtrace-nested.phpt
M Zend/tests/fibers/debug-backtrace.phpt
M Zend/tests/fibers/failing-fiber.phpt
M Zend/tests/fibers/failing-nested-fiber.phpt
M Zend/tests/fibers/get-return-after-bailout.phpt
M Zend/tests/fibers/no-switch-force-close-finally.phpt
M Zend/tests/fibers/no-switch-gc.phpt
M Zend/tests/fibers/resume-previous-fiber.phpt
M Zend/tests/fibers/resume-running-fiber.phpt
M Zend/tests/fibers/signal-async.phpt
M Zend/tests/fibers/signal-dispatch.phpt
M Zend/tests/fibers/start-arguments.phpt
M Zend/tests/fibers/suspend-in-force-close-fiber-after-shutdown.phpt
M Zend/tests/fibers/suspend-in-force-close-fiber.phpt
M Zend/tests/fibers/throw-during-fiber-destruct.phpt
M Zend/tests/fibers/throw-in-multiple-destroyed-fibers-after-shutdown.phpt
M Zend/tests/fibers/ticks.phpt
M Zend/tests/function_arguments/call_with_trailing_comma_basic.phpt
M Zend/tests/function_arguments/sensitive_parameter_arrow_function.phpt
M Zend/tests/function_arguments/sensitive_parameter_closure.phpt
M Zend/tests/generators/gh11028_2.phpt
M Zend/tests/gh10695_4.phpt
M Zend/tests/gh8810_3.phpt
M Zend/tests/gh8841.phpt
M Zend/tests/gh9916-009.phpt
M Zend/tests/match/029.phpt
M Zend/tests/match/030.phpt
M Zend/tests/named_params/call_user_func.phpt
M Zend/tests/nested_method_and_function.phpt
M Zend/tests/ns_073.phpt
M Zend/tests/return_types/011.phpt
M Zend/tests/return_types/012.phpt
M Zend/tests/return_types/013.phpt
M Zend/tests/type_declarations/callable_001.phpt
M Zend/tests/type_declarations/scalar_basic.phpt
M Zend/tests/type_declarations/scalar_none.phpt
M Zend/tests/type_declarations/scalar_null.phpt
M Zend/tests/type_declarations/scalar_return_basic_64bit.phpt
M Zend/tests/type_declarations/scalar_strict_64bit.phpt
M Zend/tests/type_declarations/scalar_strict_basic.phpt
M Zend/tests/type_declarations/static_type_return.phpt
M Zend/tests/type_declarations/typed_properties_055.phpt
M Zend/tests/type_declarations/union_types/type_checking_strict.phpt
M Zend/tests/type_declarations/union_types/type_checking_weak.phpt
M Zend/tests/type_declarations/variance/loading_exception1.phpt
M Zend/tests/type_declarations/variance/loading_exception2.phpt
M Zend/tests/undef_var_in_verify_return.phpt
M Zend/tests/use_unlinked_class.phpt
M Zend/zend_closures.c
M Zend/zend_compile.c
M Zend/zend_language_parser.y
M ext/ffi/tests/bug79177.phpt
M ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt
M ext/opcache/tests/jit/assign_055.phpt
M ext/opcache/tests/jit/closure_001.phpt
M ext/opcache/tests/jit/fetch_dim_rw_004.phpt
M ext/opcache/tests/jit/fetch_obj_006.phpt
M ext/opcache/tests/jit/not_003.phpt
M ext/reflection/tests/007.phpt
M ext/reflection/tests/ReflectionFiber_basic.phpt
M ext/reflection/tests/ReflectionFiber_bug_gh11121_1.phpt
M ext/reflection/tests/ReflectionFiber_bug_gh11121_2.phpt
M ext/reflection/tests/ReflectionFiber_notrace_2.phpt
M ext/reflection/tests/ReflectionGenerator_basic.phpt
M ext/reflection/tests/ReflectionGenerator_in_Generator.phpt
M ext/reflection/tests/bug80299.phpt
M ext/reflection/tests/closures_003_v1.phpt
M ext/spl/tests/bug71236.phpt
M ext/spl/tests/bug72051.phpt
M ext/spl/tests/spl_autoload_013.phpt
M ext/standard/tests/array/array_map_variation10.phpt
M ext/standard/tests/array/array_walk_closure.phpt
M ext/standard/tests/array/bug52719.phpt
M ext/standard/tests/array/uasort_variation7.phpt
M ext/standard/tests/array/usort_variation7.phpt
M ext/standard/tests/serialize/bug30234.phpt
M ext/xml/tests/XML_OPTION_PARSE_HUGE_during_parsing.phpt
M ext/zend_test/tests/gh10695_2.phpt
M ext/zend_test/tests/observer_backtrace_01.phpt
M ext/zend_test/tests/observer_closure_01.phpt
M ext/zend_test/tests/observer_error_05.phpt
M ext/zend_test/tests/observer_fiber_01.phpt
M ext/zend_test/tests/observer_fiber_02.phpt
M ext/zend_test/tests/observer_fiber_03.phpt
M ext/zend_test/tests/observer_fiber_04.phpt
M ext/zend_test/tests/observer_fiber_05.phpt
M ext/zend_test/tests/observer_fiber_06.phpt
M ext/zend_test/tests/observer_fiber_functions_01.phpt
M ext/zend_test/tests/observer_fiber_functions_02.phpt
M ext/zend_test/tests/observer_fiber_functions_03.phpt
M ext/zend_test/tests/observer_shutdown_01.phpt
M sapi/phpdbg/tests/exceptions_001.phpt
M sapi/phpdbg/tests/exceptions_002.phpt
M sapi/phpdbg/tests/gh13827.phpt
M scripts/dev/bless_tests.php
Diff exceeded maximum size.