[php-src] master: [ci skip] Be more specific about ext-dom incompatibilities in UPGRADING (#14024)
| From: | Niels Dossche via GitHub | Date: | Sat, 20 Apr 2024 21:21:48 +0000 |
| Subject: | [php-src] master: [ci skip] Be more specific about ext-dom incompatibilities in UPGRADING (#14024) | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-128183@lists.php.net to get a copy of this message | ||
Author: Niels Dossche (nielsdos)
Committer: GitHub (web-flow)
Pusher: nielsdos
Date: 2024-04-20T23:21:40+02:00
Commit: https://github.com/php/php-src/commit/7428a92c5b2ed7d6a755b86f37ec7b82d34753a2
Raw diff: https://github.com/php/php-src/commit/7428a92c5b2ed7d6a755b86f37ec7b82d34753a2.diff
[ci skip] Be more specific about ext-dom incompatibilities in UPGRADING (#14024)
The previous text was put there before I decided to add the new classes.
Therefore the only new feature that can affect BC is
compareDocumentPosition(). Only when the declaration is incompatible can
the user experience errors.
Changed paths:
M UPGRADING
Diff:
diff --git a/UPGRADING b/UPGRADING
index ad6e5b839a8a..bcd828253033 100644
--- a/UPGRADING
+++ b/UPGRADING
@@ -31,11 +31,10 @@ PHP 8.4 UPGRADE NOTES
. The type of PHP_DEBUG and PHP_ZTS constants changed to bool.
- DOM:
- . New methods and constants were added to some DOM classes. If you inherit
- from these and you happen to have a method or property with the same name,
- you might encounter errors if the declaration is incompatible.
- Consult sections 2. New Features and 6. New Functions for a list of
- newly implemented methods and constants.
+ . Added DOMNode::compareDocumentPosition() and DOMNode::DOCUMENT_POSITION_*
+ constants.
+ If you have a method or constant with the same name, you might encounter errors
+ if the declaration is incompatible.
. Some DOM methods previously returned false or a PHP_ERR DOMException if a new
node could not be allocated. They consistently throw an INVALID_STATE_ERR
DOMException now. This situation is extremely unlikely though and probably