Re: cvs: php4 /ext/standard info.c
| From: | Ilia A. | Date: | Sun, 04 Aug 2002 20:03:14 +0000 |
| Subject: | Re: cvs: php4 /ext/standard info.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-13116@lists.php.net to get a copy of this message | ||
On August 4, 2002 03:27 pm, you wrote:
> At 20:57 04.08.2002, Georg Richter wrote:
> >georg Sun Aug 4 14:57:02 2002 EDT
> >
> > Modified files:
> > /php4/ext/standard info.c
> > Log:
> > added meta tag (w3c compliance)
> > Thx to Ilia Alshanetsky (ilia@prohost.org)
>
> That's not really correct because the charset can be changed by ini
> settings: output_handler = mb_output_handler
> mbstring.http_output=<charset>
>
> Besides: nowhere in HTML4.01 standard is said that you need "Content-Type"
> meta tag. Instead you should have to inform about charset in http message
> envelope.
> So i think the meta tag should be removed.
>
> marcus
First here is the W3C document identifying the fact that charset is defined.
http://www.w3.org/International/O-charset.html
Since PHP's Content-Type header only contains 'text/html' it should be
specified in a meta tag. As far as I know phpinfo() output is always in
english regardless of the machine's charset settings, therefor charset should
always be set to 'iso-8859-1', regardless of what the user generated pages
send as their charset.
Ilia
>
> >Index: php4/ext/standard/info.c
> >diff -u php4/ext/standard/info.c:1.184 php4/ext/standard/info.c:1.185
> >--- php4/ext/standard/info.c:1.184 Mon Jul 1 14:52:30 2002
> >+++ php4/ext/standard/info.c Sun Aug 4 14:57:02 2002
> >@@ -17,7 +17,7 @@
> >
> > +----------------------------------------------------------------------+
> > */
> >
> >-/* $Id: info.c,v 1.184 2002/07/01 18:52:30 derick Exp $ */
> >+/* $Id: info.c,v 1.185 2002/08/04 18:57:02 georg Exp $ */
> >
> > #include "php.h"
> > #include "php_ini.h"
> >@@ -216,7 +216,7 @@
> > PUTS("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01
> > Transitional//EN\">\n<html>\n");
> > PUTS("<head>");
> > php_info_print_style();
> >- PUTS("<title>phpinfo()</title></head><body>");
> >+ PUTS("<title>phpinfo()</title><meta
> >http-equiv=\"Content-Type\"
> >content=\"text/html; charset=ISO-8859-1\">/head><body>");
> >
> > if (flag & PHP_INFO_GENERAL) {
> > char *zend_version = get_zend_version();
> >
> >
> >
> >--
> >PHP CVS Mailing List (http://www.php.net/)
> >To unsubscribe, visit: http://www.php.net/unsub.php