Re: cvs: php4 /ext/standard dns.c

On August 29, 2002 11:51 am, you wrote: > > + if (!hp || hp->h_name == NULL || hp->h_name == '\0') { > > Are you sure this is correct? Shouldn't it be *hp->h_name == '\0'? > (Didn't look into the code, though.) > > Sander You are correct, either *hp->h_name or hp->h_name[0] should be used, I'll correct this behaviour momentarily. Ilia > > On Thu, Aug 29, 2002 at 03:44:01PM -0000, Ilia Alshanetsky wrote: > > iliaa Thu Aug 29 11:44:01 2002 EDT > > > > Modified files: > > /php4/ext/standard dns.c > > Log: > > Fixed bug #18966 > > > > > > Index: php4/ext/standard/dns.c > > diff -u php4/ext/standard/dns.c:1.40 php4/ext/standard/dns.c:1.41 > > --- php4/ext/standard/dns.c:1.40 Fri Aug 23 21:19:27 2002 > > +++ php4/ext/standard/dns.c Thu Aug 29 11:44:00 2002 > > @@ -16,7 +16,7 @@ > > > > +----------------------------------------------------------------------+ > > */ > > > > -/* $Id: dns.c,v 1.40 2002/08/24 01:19:27 helly Exp $ */ > > +/* $Id: dns.c,v 1.41 2002/08/29 15:44:00 iliaa Exp $ */ > > > > /* {{{ includes > > */ > > @@ -128,7 +128,7 @@ > > hp = gethostbyaddr((char *) &addr, sizeof(addr), AF_INET); > > #endif > > > > - if (!hp) { > > + if (!hp || hp->h_name == NULL || hp->h_name == '\0') { > > return estrdup(ip); > > } > > > > > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php