[php-src] master: standard/filestats.c: use RETURN_BOOL() when possible (#22876)

From: Date: Sat, 25 Jul 2026 10:37:03 +0000
Subject: [php-src] master: standard/filestats.c: use RETURN_BOOL() when possible (#22876)
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-140211@lists.php.net to get a copy of this message
Author: Gina Peter Banyard (Girgias) Committer: GitHub (web-flow) Pusher: Girgias Date: 2026-07-25T11:37:00+01:00 Commit: https://github.com/php/php-src/commit/bf46492421b4b74247285a591d7251b53e0a7191 Raw diff: https://github.com/php/php-src/commit/bf46492421b4b74247285a591d7251b53e0a7191.diff standard/filestats.c: use RETURN_BOOL() when possible (#22876) Changed paths: M ext/standard/filestat.c Diff: diff --git a/ext/standard/filestat.c b/ext/standard/filestat.c index f7bda3c66bab..7dcfecf1f872 100644 --- a/ext/standard/filestat.c +++ b/ext/standard/filestat.c @@ -339,11 +339,7 @@ static void php_do_chgrp(INTERNAL_FUNCTION_PARAMETERS, int do_lchgrp) /* {{{ */ value = &group_long; } - if(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)) { - RETURN_TRUE; - } else { - RETURN_FALSE; - } + RETURN_BOOL(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)); } else { #ifndef PHP_WIN32 /* On Windows, we expect regular chgrp to fail silently by default */ @@ -480,11 +476,7 @@ static void php_do_chown(INTERNAL_FUNCTION_PARAMETERS, int do_lchown) /* {{{ */ value = &user_long; } - if(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)) { - RETURN_TRUE; - } else { - RETURN_FALSE; - } + RETURN_BOOL(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)); } else { #ifndef PHP_WIN32 /* On Windows, we expect regular chown to fail silently by default */ @@ -638,11 +630,7 @@ PHP_FUNCTION(touch) wrapper = php_stream_locate_url_wrapper(filename, NULL, 0); if(wrapper != &php_plain_files_wrapper || strncasecmp("file://", filename, 7) == 0) { if(wrapper && wrapper->wops->stream_metadata) { - if(wrapper->wops->stream_metadata(wrapper, filename, PHP_STREAM_META_TOUCH, newtime, NULL)) { - RETURN_TRUE; - } else { - RETURN_FALSE; - } + RETURN_BOOL(wrapper->wops->stream_metadata(wrapper, filename, PHP_STREAM_META_TOUCH, newtime, NULL)); } else { php_stream *stream; if(!filetime_is_null || !fileatime_is_null) {

« previous php.cvs (#140211) next »