[php-src] PHP-8.4: Fix GH-23842: skipLazyInitialization() copies unresolved constant defaults

From: Date: Tue, 29 Sep 2026 19:40:27 +0000
Subject: [php-src] PHP-8.4: Fix GH-23842: skipLazyInitialization() copies unresolved constant defaults
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-141725@lists.php.net to get a copy of this message
Author: lazerg (lazerg) Committer: ndossche (ndossche) Date: 2026-09-29T21:39:12+02:00 Commit: https://github.com/php/php-src/commit/e0eea65aa447805c677a9fb0a33bbc65cd79eb68 Raw diff: https://github.com/php/php-src/commit/e0eea65aa447805c677a9fb0a33bbc65cd79eb68.diff Fix GH-23842: skipLazyInitialization() copies unresolved constant defaults Closes GH-23843. Changed paths: A Zend/tests/lazy_objects/gh23842.phpt M NEWS M ext/reflection/php_reflection.c Diff: diff --git a/NEWS b/NEWS index e5441fe6bc26..0ec3c10f0a12 100644 --- a/NEWS +++ b/NEWS @@ -404,6 +404,8 @@ PHP NEWS parent slot when a child class hooks an inherited property. (iliaal) . Fixed segfault in ReflectionMethod::createFromMethodName() on an uninstantiable subclass. (iliaal) + . Fixed bug GH-23842 (ReflectionProperty::skipLazyInitialization() copies + invalid constant defaults with OPcache). (DirkTrunkstar, Lazizbek Ergashev) - Readline: . Fixed class constant completion in the interactive shell. (Weilin Du) diff --git a/Zend/tests/lazy_objects/gh23842.phpt b/Zend/tests/lazy_objects/gh23842.phpt new file mode 100644 index 000000000000..fe791dde685b --- /dev/null +++ b/Zend/tests/lazy_objects/gh23842.phpt @@ -0,0 +1,32 @@ +--TEST-- +GH-23842: skipLazyInitialization() copies an unresolved constant default with opcache +--CREDITS-- +DirkTrunkstar +--EXTENSIONS-- +opcache +--INI-- +opcache.enable=1 +opcache.enable_cli=1 +opcache.file_cache_only=0 +--FILE-- +<?php + +class Currency { + public const string EUR = 'EUR'; +} + +class Product { + public string $currency = Currency::EUR; +} + +$reflector = new ReflectionClass(Product::class); +$product = $reflector->newLazyGhost(function () { + throw new \Exception('initializer'); +}); +$reflector->getProperty('currency')->skipLazyInitialization($product); + +var_dump($product->currency); + +?> +--EXPECT-- +string(3) "EUR" diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c index c7b15c63a0c5..2c94a6e80d18 100644 --- a/ext/reflection/php_reflection.c +++ b/ext/reflection/php_reflection.c @@ -6461,7 +6461,7 @@ ZEND_METHOD(ReflectionProperty, skipLazyInitialization) RETURN_THROWS(); } - zval *src = &object->ce->default_properties_table[OBJ_PROP_TO_NUM(prop->offset)]; + zval *src = &CE_DEFAULT_PROPERTIES_TABLE(object->ce)[OBJ_PROP_TO_NUM(prop->offset)]; zval *dst = OBJ_PROP(object, prop->offset); if (!(Z_PROP_FLAG_P(dst) & IS_PROP_LAZY)) {

« previous php.cvs (#141725) next »