Re: cvs: php4 /main main.c
| From: | Sascha Schumann | Date: | Sun, 27 Aug 2000 20:25:28 +0000 |
| Subject: | Re: cvs: php4 /main main.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-1426@lists.php.net to get a copy of this message | ||
On Sun, 27 Aug 2000, Andi Gutmans wrote:
> andi Sun Aug 27 12:51:50 2000 EDT
>
> Modified files:
> /php4/main main.c
> Log:
> - Reverting Sascha's patch although I don't like doing these kind of things
> - but as it is Sascha who has reverted a zillion patches I don't feel that
> - bad about it :)
> - The patch is morally incorrect and it actually also has a crash bug which
> - I won't point out because it shouldn't be there.
Can we please leave this kind of comments out of commit
messages? First, you are not the moral instance of the church
of PHP. Second, if you insist on moving this code it would be
helpful to add where you are seeing a bug.
- Sascha