Re: cvs: php4 /ext/standard css.c

At 21:42 8-10-2002, Colin Viebrock wrote:

cmv             Tue Oct  8 15:42:23 2002 EDT

Modified files:

    /php4/ext/standard  css.c

Log: don't define fonts ... use the browser defaults

Reason being? The definitions end in generic font families. There's no shame in defining a __readable__ __preference__. Especially Andale Mono, since it is one of the few monotype fonts, that has a readable difference between the l and a 1 and the O and 0. I've seen more people fiddling with their fonts, because "they're pretty" than because they're readable. Docs should aim to be readable. What's more problematic in the css code below, is the 75% default on td/th. If you nest that, the inner td, is 75% of 75% of the body.

Index: php4/ext/standard/css.c diff -u php4/ext/standard/css.c:1.2 php4/ext/standard/css.c:1.3 --- php4/ext/standard/css.c:1.2 Thu Sep 26 13:54:53 2002

+++ php4/ext/standard/css.c     Tue Oct  8 15:42:23 2002

@@ -16,7 +16,7 @@

    +----------------------------------------------------------------------+

*/ -/* $Id: css.c,v 1.2 2002/09/26 17:54:53 cmv Exp $ */ +/* $Id: css.c,v 1.3 2002/10/08 19:42:23 cmv Exp $ */ #include "php.h" #include "info.h" @@ -29,15 +29,15 @@

        TSRMLS_FETCH();

        PUTS("body {background-color: #ffffff; color: #000000;}\n");
-       PUTS("body, td, th, h1, h2 {font-family: arial, helvetica, sans-serif;}\n");
-       PUTS("pre {margin: 0px; font-family: \"andale mono\", \"monotype.com\", \"courier new\", courier, monospace;}\n");
+       PUTS("body, td, th, h1, h2 {font-family: sans-serif;}\n");
+       PUTS("pre {margin: 0px; font-family: monospace;}\n");
        PUTS("a:link {color: #000099; text-decoration: none;}\n");
        PUTS("a:hover {text-decoration: underline;}\n");
        PUTS("table {border-collapse: collapse;}\n");
        PUTS("td, th { border: 1px solid #000000; font-size: 75%; vertical-align: baseline;}\n");
        PUTS("h1 {font-size: 150%;}\n");
-       PUTS(".p {text-align: left;}\n");
        PUTS("h2 {font-size: 125%;}\n");
+       PUTS(".p {text-align: left;}\n");
        PUTS(".e {background-color: #ccccff; font-weight: bold;}\n");
        PUTS(".h {background-color: #9999cc; font-weight: bold;}\n");
        PUTS(".v {background-color: #cccccc;}\n");

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua