Re: cvs: php4 /ext/gd/libgd gd_topal.c
| From: | Rasmus Lerdorf | Date: | Thu, 17 Oct 2002 06:25:14 +0000 |
| Subject: | Re: cvs: php4 /ext/gd/libgd gd_topal.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-14982@lists.php.net to get a copy of this message | ||
> On Wed, Oct 16, 2002 at 11:12:25PM -0700, Rasmus Lerdorf wrote :
> > It's not an optional arg though. So by leaving it off, do you mean if an
> > invalid value is given? I don't like changing args like that.
>
> Yes I know it's not optional. But having it default to 256
> colors makes sense if the value is not given (I think).
So you are saying you want to make it optional? Because as it is there is
no way to not give a value.
> Another thing I just saw: if you pass a negative value to the
> last parameter it segfaults too ....
After my patch? I check for <= 0
-Rasmus