Re: cvs: php4 /ext/mbstring/tests 027.inc 027.phpt

Hi! On Mon, 21 Oct 2002, Yasuo Ohgaki wrote: > Derick Rethans wrote: > > > > Why do you use an include file for this? This makes maintaining it > > harder, please include it in the test script itself. > > > > Most mbstring tests are written by me. > For me, hard coding php script in phpt is hard to maintain. > i.e. I cannot execute it directly. That's why you can run only one test with: PHP_TEST_EXECUTABLE=sapi/cli/php php run-tests ext/mbstring/tests/027.phpt > It's upto personal preference as long as consistent > in the module, IMO. I don't agree with that; if everybody did things up to their own preference I would have coded all my tests scripts in one line without whitespace, that's much fastter you know? Anyway, for the overal quality of the test suite I want all tests implemented the same. It's either you or me who's going to change it. regards, Derick -- --------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --------------[ if you hold a unix shell to your ear, do you hear the c? ]-