Re: cvs: php4 /ext/standard/tests/strings strtoupper.phpt

Nice test and additional skip logic but i think we should use characters available in germany like our umlauts. I suspect the test fails for me because my locale does not recognize the three characters used which are non german characters anyway... marcus At 01:04 24.10.2002, Ilia Alshanetsky wrote:

iliaa           Wed Oct 23 19:04:43 2002 EDT

Modified files:

    /php4/ext/standard/tests/strings    strtoupper.phpt

Log: Added 'skip logic' to the test on platforms where the locale required by this test is not avaliable. Index: php4/ext/standard/tests/strings/strtoupper.phpt diff -u php4/ext/standard/tests/strings/strtoupper.phpt:1.1 php4/ext/standard/tests/strings/strtoupper.phpt:1.2 --- php4/ext/standard/tests/strings/strtoupper.phpt:1.1 Tue Oct 22 15:39:17 2002

+++ php4/ext/standard/tests/strings/strtoupper.phpt     Wed Oct 23 19:04:43 2002

@@ -1,17 +1,20 @@ --TEST-- Test strtoupper on non-ASCII characters ---POST-- ---GET-- +--SKIPIF-- +<?php +if (!setlocale(LC_CTYPE, "de_DE", "de", "german", "ge")) {

+        die("skip locale needed for this test is not supported on this platform");

+} +?> --FILE-- <?php $chars = "àëï"; -setlocale(LC_ALL, "C"); // Not sure which is most portable. BSD's answer to // this one. A small array based on PHP_OS should // cover a majority of systems and makes the problem // of locales transparent for the end user. -setlocale(LC_CTYPE, "ISO8859-1"); -print(strtoupper($chars)); +setlocale(LC_CTYPE, "de_DE", "de", "german", "ge"); +echo strtoupper($chars)."\n"; ?> --EXPECT-- -ÄËÏ +ÀËÏ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php