Re: cvs: php4 / acinclude.m4 configure.in /ext/standard config.m4 math.c
| From: | Derick Rethans | Date: | Thu, 24 Oct 2002 12:31:59 +0000 |
| Subject: | Re: cvs: php4 / acinclude.m4 configure.in /ext/standard config.m4 math.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-15354@lists.php.net to get a copy of this message | ||
On Thu, 24 Oct 2002, Sascha Schumann wrote:
> sas Thu Oct 24 08:21:07 2002 EDT
>
> Modified files:
> /php4 acinclude.m4 configure.in
> /php4/ext/standard config.m4 math.c
> Log:
> Make PHP compile out-of-the-box with uClibc
>
>
> PHP_FUNCTION(asinh)
> {
> +#ifdef HAVE_ASINH
> zval **num;
>
> if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &num) == FAILURE) {
> @@ -329,6 +330,7 @@
> convert_to_double_ex(num);
> Z_DVAL_P(return_value) = asinh(Z_DVAL_PP(num));
> Z_TYPE_P(return_value) = IS_DOUBLE;
> +#endif
> }
I thought the general consesus was to not define a function at all if it
is not implemented. Better make function_exists() work on them so that
you can code workarounds in your code...
Derick
--
---------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
JDI Media Solutions
--------------[ if you hold a unix shell to your ear, do you hear the c? ]-