Re: cvs: php4 /ext/domxml/tests 001.phpt

Could you put this explanation than into the test... marcus At 19:30 24.10.2002, Ilia A. wrote:

The test has a recursive reference which is what is causing it in the 1st place. The goal of the test is to determine whether or not the output provided by the functions is correct and whether or not the used code could result in a crash (segmentation fault). The memory leaks, which I had mentioned are the result of recursive references are 'dynamic' and depend on numerous functors such as ini settings, --enable-debug and even the Zend Engine version. Thus leaving them in would result in this test always failing, despite the actual output of the script being correct. As far as I understand the situation, this particular test cannot be rewritten in such a way as to avoid the memory leak and without loosing its ability to detect potential problems. Ilia On October 24, 2002 01:20 pm, Marcus Börger wrote: This should be the other way round. A Test must be done without any memoryleak. And so there is no difference between debug and non-debug versions of php. The only exception to this rule would be to check if setting that options works. But then we needed a function that would generate a memleak on demand. marcus At 19:02 24.10.2002, Ilia Alshanetsky wrote:

iliaa           Thu Oct 24 13:02:44 2002 EDT

Modified files:

    /php4/ext/domxml/tests      001.phpt

Log: Added an ini option to hide the expected memory leak. This is done for compatibility with systems where report_memleak is turned off or running PHP with --disable-debug. Index: php4/ext/domxml/tests/001.phpt diff -u php4/ext/domxml/tests/001.phpt:1.3 php4/ext/domxml/tests/001.phpt:1.4 --- php4/ext/domxml/tests/001.phpt:1.3 Fri Oct 11 10:02:59 2002

+++ php4/ext/domxml/tests/001.phpt      Thu Oct 24 13:02:44 2002

@@ -1,11 +1,10 @@ --TEST-- Test 1: Accessing single node +--INI-- +report_memleaks=0 --SKIPIF-- <?php if(!extension_loaded("domxml")) print "skip"; ?> ---POST-- ---GET-- --FILE-- - <?php require_once("domxml_test.inc"); -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php