Re: cvs: php4 /ext/standard file.c /ext/standard/tests/strings strtoupper.phpt
| From: | Melvyn Sopacua | Date: | Thu, 24 Oct 2002 19:50:07 +0000 |
| Subject: | Re: cvs: php4 /ext/standard file.c /ext/standard/tests/strings strtoupper.phpt | ||
| References: | 1 | Groups: | php.cvs php.qa |
| Request: | Send a blank email to php-cvs+get-15395@lists.php.net to get a copy of this message | ||
At 21:27 24-10-2002, Marcus Börger wrote:
The test PASSES on my system. So the question is why should it be skipped on BSD or if not why does it fail?It shouldn't be skipped, that's why I added the locale for FreeBSD. The other question I can't answer - all I know is, that 4.2.3 handles it correctly and 4.3.0 doesn't . I can try and trace this through all the commits on string.c, but will have to wait until the weekend. http://cvs.php.net/diff.php/php4/ext/standard/string.c?r1=1.263.2.6&r2=1..328&ty=h Then again - it may related to completely different settings :( If there are volunteers for the job, with BSD systems - be my guest :)
It seems that the skip logic is done well. marcus At 21:17 24.10.2002, Melvyn Sopacua wrote:Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua(...)msopacua Thu Oct 24 15:17:09 2002 EDTModified files:/php4/ext/standard file.c /php4/ext/standard/tests/strings strtoupper.phptLog: - Add locale string for FreeBSD ATTN: Test nog longer skips, but fails. So whatever has changed since 4.2.3 affects BSD systems.