Re: cvs: php4 /ext/mbstring mbstring.c

Derick Rethans wrote:

On Sat, 26 Oct 2002, Yasuo Ohgaki wrote:

yohgaki Fri Oct 25 22:08:05 2002 EDT

 Modified files:                 /php4/ext/mbstring	mbstring.c  Log:

Remove useless check. # Problem was in other place

For once: DISCUSS things before you remove patches by others. I don't care if it was wrong, but removing code added by others without DISCUSSing is considered quite RUDE. (Just like typing in capitals).

Derick, This is obvious from CVS and source. Here is what happened. Moriyoshi assigned val = NULL by mistake, which shouldn't be done in first place. You patched to workaround that. Moriyoshi noticed his mistake and fix where should be, but he just forgot remove workaround you added. I just removed it, it may be left there forever if I forgot to remove it. I think it's obvious to me from CVS log, isn't? (And I know well there weren't such bug before) I didn't complain in the log you've committed bogus patch, etc. As a matter of fact, I think it's nice catch ;) If I were you, I would appreciate patches like this simple clean up, especially patches from people know the code well. -- Yasuo Ohgaki