Re: cvs: php4 /ext/iconv/tests

Hi, Excuse me for being late here. I figured out the problem though skipif.inc was not my work. I'll remove them soon. I think I should get rid of dl() code from htmlentities test cases too. Regards, Moriyoshi Melvyn Sopacua <msopacua@idg.nl> wrote: > At 19:36 28-10-2002, Marcus Bger wrote: > > >Then what about: > > > >cvs -z3 -q diff skipif.inc test.inc (in directory > >S:\php4-HEAD\ext\iconv\tests\) > >Index: skipif.inc > >=================================================================== > >RCS file: /repository/php4/ext/iconv/tests/skipif.inc,v > >retrieving revision 1.2 > >diff -u -r1.2 skipif.inc > >--- skipif.inc 28 Oct 2002 17:15:21 -0000 1.2 > >+++ skipif.inc 28 Oct 2002 18:35:25 -0000 > >@@ -1,10 +1,11 @@ > > <?php > > // This script prints "skip" if condition does not meet. > > > >-if (!extension_loaded("iconv") && ini_get("enable_dl")) { > >- $dlext = (substr(PHP_OS, 0, 3) == "WIN") ? ".dll" : ".so"; > >- @dl("iconv$dlext"); > >-} > >+// Do not dl load extension > >+//if (!extension_loaded("iconv") && ini_get("enable_dl")) { > >+// $dlext = (substr(PHP_OS, 0, 3) == "WIN") ? ".dll" : > >".so"; > >+// @dl("iconv$dlext"); > >+//} > > if (!extension_loaded("iconv")) { > > die("skip iconv extension not available\n"); > > } > > Yeah, that's what it should be, when we decide to strike the dl() > for lack of a foolproof alternative. > > The problem is twofold: loading the right filename (so/dll/foo) and > loading the right VERSION, ie the one just built in $source_root/modules > or $source_root/(RELEASE_TS|DEBUG_TS). > > We could of course look for getenv('DL_LOAD_DIR') and getenv('DL_EXT'), > and document this properly, so the user is able to test his shared modules. > > Food time :) > > > Met vriendelijke groeten / With kind regards, > > Webmaster IDG.nl > Melvyn Sopacua > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >