Re: cvs: php4 /build buildcheck.sh

> 1. bison is not invoked during buildconf, so why the heck was the check > embedded here. a) Bison is needed for CVS builds b) Bison is not needed for snapshot/release builds c) buildconf is needed for CVS builds > 2. bison 1.35 works fine for ze1. if there is a problem with ze2, the > check should be limited to that ze version. don't inconvenience people > who are using a perfectly fine combination. Bison versions above 1.28 have been reported (e.g. by Andi) to not work. Bison 1.50 definately does not work. Bison 1.75 seems to work though. Please revert this and start acting like the rest of us and DISCUSS before removing stuff. There was perfectly valid reason to have this here. --Jani > >Index: php4/build/buildcheck.sh >diff -u php4/build/buildcheck.sh:1.20 php4/build/buildcheck.sh:1.21 >--- php4/build/buildcheck.sh:1.20 Sun Oct 27 14:47:34 2002 >+++ php4/build/buildcheck.sh Wed Oct 30 06:42:22 2002 >@@ -16,7 +16,7 @@ > # | Sascha Schumann <sascha@schumann.cx> | > # +----------------------------------------------------------------------+ > # >-# $Id: buildcheck.sh,v 1.20 2002/10/27 19:47:34 sniper Exp $ >+# $Id: buildcheck.sh,v 1.21 2002/10/30 11:42:22 sas Exp $ > # > > echo "buildconf: checking installation..." >@@ -68,25 +68,6 @@ > exit 1 > else > echo "buildconf: automake version $am_version (ok)" >-fi >- >-# Bison <= 1.30 or >= 1.75 required (1.35, 1.50 have some bugs) >-bison_version=bison --version| grep 'GNU Bison' | cut -d ' >' -f 4 >-bison_version_clean=echo $bison_version|sed -e >'s/-p[0-9]*$//' >-if test "$bison_version" = ""; then >-echo "buildconf: bison not found." >-echo " You need bison version <= 1.30 >= 1.75 installed" >-echo " to build PHP from CVS." >-exit 1 >-fi >-IFS=.; set $bison_version_clean; IFS=' ' >-if test "$1" = "1" -a "$2" -le "30" || test >"$1" = "1" -a "$2" -ge "75"; then >-echo "buildconf: bison version $bison_version (ok)" >-else >-echo "buildconf: bison version $bison_version found." >-echo " You need bison version <= 1.30 >= 1.75 installed" >-echo " to build PHP from CVS." >-exit 1 > fi > > # libtool 1.4 or newer > > > > -- <- For Sale! ->