Re: cvs: php4 /ext/xslt/tests xslt_process-001.phpt xslt_set_object.phpt xslt_setopt.phpt

At 11:38 30.10.2002, Melvyn Sopacua wrote:

At 22:57 29-10-2002, Marcus Börger wrote:

--use var_dump()

Why? Please Marcus - discuss with the person who developed the test before altering it's behavior. What's the positive side of using var_dump?

I saw no need in first comparing results and then compare the result of the compare again in run-test.php. The far better way seems to present the output and compare the expected output in run-test.php. The reason i did was that i was wondering what i would do when i got any .diff .out from a user for whom the test faild? I would receive somthing like "unexpected result". Wow that would be a good help in finding the bug.

Here are the negatives: -- iconv could be unsupported (which was on my list of things to fix for this and other tests) If the entity fails, it fails in both cases and so the meta test succeeds but, just because a character misses the test fails for no good reason.

We can rewrite the test so it becomes independant from iconv.

-- indenting is something being discussed on the Sablist and so may change and can be platform specific. However indenting is handled, it will be handled consistently for a platform.

If above is reason enough to display the full result we could use --EXPECTREGEX-- und skip over any whitespace. But your original compare would be much easier. Perhaps use your compare and var_dump on failure?

IMO comparison is the way to do it here, not var_dump. Let's here the positives? Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua