Re: cvs: TSRM / tsrm_virtual_cwd.h

Ilia, This patch isn't correct. The reason is that IS_ABSOLUTE_PATH() is often followed by COPY_WHEN_ABSOLUTE(). i.e absolute paths on Windows are supposed to start with c: and then always two chars are copied. I'm aware there might be a problem which needs fixing but this definitely doesn't seem to be right. Please revert this patch from both branches and let's discuss it. Thanks, Andi At 01:45 PM 11/14/2002 +0000, Ilia Alshanetsky wrote:

iliaa           Thu Nov 14 08:45:08 2002 EDT

Modified files:

    /TSRM       tsrm_virtual_cwd.h

Log: Fix bug 19689, solution suggested by dmitry@koteroff.ru. Index: TSRM/tsrm_virtual_cwd.h diff -u TSRM/tsrm_virtual_cwd.h:1.25 TSRM/tsrm_virtual_cwd.h:1.26

--- TSRM/tsrm_virtual_cwd.h:1.25        Wed Nov  6 13:07:22 2002
+++ TSRM/tsrm_virtual_cwd.h     Thu Nov 14 08:45:08 2002

@@ -17,7 +17,7 @@

    +----------------------------------------------------------------------+

*/ -/* $Id: tsrm_virtual_cwd.h,v 1.25 2002/11/06 18:07:22 iliaa Exp $ */ +/* $Id: tsrm_virtual_cwd.h,v 1.26 2002/11/14 13:45:08 iliaa Exp $ */ #ifndef VIRTUAL_CWD_H #define VIRTUAL_CWD_H @@ -58,7 +58,7 @@ */ #define COPY_WHEN_ABSOLUTE(path) 2 #define IS_ABSOLUTE_PATH(path, len) \

-       (len >= 2 && isalpha(path[0]) && path[1] == ':')
+       ((len >= 2 && isalpha(path[0]) && path[1] == ':') || (len >= 1 && IS_SLASH(path[0])))

#define IS_UNC_PATH(path, len) \

        (len >= 2 && IS_SLASH(path[0]) && IS_SLASH(path[1]))

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php