Re: cvs: php4 /ext/session session.c

On Wed, 20 Nov 2002, Sascha Schumann wrote: >sas Wed Nov 20 11:06:29 2002 EDT > > Modified files: > /php4/ext/session session.c > Log: > add protective checks to ini updates > > Noticed by: Derick Rethans <d.rethans@jdimedia.nl> > PR: #20284 Don't forget to close the bug report..and do MFH. :) --Jani > >Index: php4/ext/session/session.c >diff -u php4/ext/session/session.c:1.336 php4/ext/session/session.c:1.337 >--- php4/ext/session/session.c:1.336 Thu Oct 24 06:40:48 2002 >+++ php4/ext/session/session.c Wed Nov 20 11:06:29 2002 >@@ -17,7 +17,7 @@ > +----------------------------------------------------------------------+ > */ > >-/* $Id: session.c,v 1.336 2002/10/24 10:40:48 sas Exp $ */ >+/* $Id: session.c,v 1.337 2002/11/20 16:06:29 sas Exp $ */ > > #ifdef HAVE_CONFIG_H > #include "config.h" >@@ -85,6 +85,8 @@ > > static PHP_INI_MH(OnUpdateSaveHandler) > { >+ if (PS(session_status) == php_session_active) >+ return; > PS(mod) = _php_find_ps_module(new_value TSRMLS_CC); > /* > * Following lines are commented out to prevent bogus error message at >@@ -102,6 +104,8 @@ > > static PHP_INI_MH(OnUpdateSerializer) > { >+ if (PS(session_status) == php_session_active) >+ return; > PS(serializer) = _php_find_ps_serializer(new_value TSRMLS_CC); > /* > * Following lines are commented out to prevent bogus error message at > > > > -- <- For Sale! ->